Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic keys for defineCommand type safety in Typescript #1876

Open
francescov1 opened this issue Apr 4, 2024 · 0 comments
Open

Dynamic keys for defineCommand type safety in Typescript #1876

francescov1 opened this issue Apr 4, 2024 · 0 comments

Comments

@francescov1
Copy link

Is there a way to make dynamic key support for defineCommand type safe? Eg currently i have this:

declare module 'ioredis' {
  interface RedisCommander<Context> {
    addUserToQueueScript(
      // keys
      activeUserChatKey: string,
      queueKey: string,
      // TODO: More keys can be added here
      
      // args
      userId: string,
      chatId: string,
      currentTimestamp: number,
      maxQueueLength: number,
      maxParallelChatRequests: number,
      callback?: Callback<string>
    ): Result<string, Context>;
  }
}

It would be great if there was a way to pass keys as a single array, so that the rest of the args can still be type safe. Something like this:

declare module 'ioredis' {
  interface RedisCommander<Context> {
    addUserToQueueScript(
      keys: string[],
     
      // args
      userId: string,
      chatId: string,
      currentTimestamp: number,
      maxQueueLength: number,
      maxParallelChatRequests: number,
      callback?: Callback<string>
    ): Result<string, Context>;
  }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant