Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ioredis@4.18 or high is not parsing URI properly #1230

Closed
Kikobeats opened this issue Nov 3, 2020 · 2 comments
Closed

ioredis@4.18 or high is not parsing URI properly #1230

Kikobeats opened this issue Nov 3, 2020 · 2 comments

Comments

@Kikobeats
Copy link

This is a thing that happened in the past (#1132) and now I'm trying to figure what's is broken, but the fact is the latest version doesn't work as expected

ioredis@4.17 -> works fine
ioredis@4.18 -> doesn't work
ioredis@4.19 -> doesn't work

4.17 vs 4.18

@Kikobeats Kikobeats changed the title ioredios 4.18 or high is not parsing URI properly ioredis@4.18 or high is not parsing URI properly Nov 3, 2020
@luin
Copy link
Collaborator

luin commented Nov 4, 2020

Hi Kiko,

The issue is pretty strange. As @AVVS said we didn't introduce any change related to this part. Can you provide a minimal reproducible example to help us understand the issue? A quick way to do that I can think of is:

const redis = new Redis(yourConnectionOptions);
console.log(redis.options); // Will 4.18 give a different result than 4.17?

@Kikobeats
Copy link
Author

Hello,

it was a thing related to a dependency using an ioredis as a dependency

https://github.com/lukechilds/keyv-redis/pull/40

so it isn't an ioredis core thing 🙂

Thanks for the support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants