Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[馃殌 Request] Remove dynamic import from TextView #889

Open
mlorinc opened this issue Jul 31, 2023 · 3 comments
Open

[馃殌 Request] Remove dynamic import from TextView #889

mlorinc opened this issue Jul 31, 2023 · 3 comments
Labels
enhancement New feature or request
Milestone
BACKLOG

Comments

@mlorinc
Copy link
Contributor

mlorinc commented Jul 31, 2023

Improper use of dynamic import on line AbstractViews.ts:94. Use standard import instead.
@mlorinc mlorinc added bug Something isn't working good-first-issue Good for newcomers new-issue New issue which was not discussed yet labels Jul 31, 2023
@goverdhan07
Copy link

hi @mlorinc isn't clipboardy a CommonJS module and does not provide an ECMAScript module version? Hence, the usage of dynamic import was the appropriate approach I feel

@mlorinc
Copy link
Contributor Author

mlorinc commented Aug 7, 2023

Hi @goverdhan07,

thank you for your comment. I did not realize node16 is used instead CommonJS in this project, so I apologize for that. Is there at least way to move import statement from function body to file header?

@djelinek djelinek added enhancement New feature or request and removed new-issue New issue which was not discussed yet bug Something isn't working labels Aug 22, 2023
@djelinek djelinek changed the title [Bug] Remove dynamic import from TextView [Improvement] Remove dynamic import from TextView Aug 22, 2023
@djelinek djelinek changed the title [Improvement] Remove dynamic import from TextView [Request] Remove dynamic import from TextView Oct 11, 2023
@djelinek djelinek changed the title [Request] Remove dynamic import from TextView [馃殌 Request] Remove dynamic import from TextView Oct 17, 2023
@djelinek djelinek added this to the NEXT milestone Oct 17, 2023
@djelinek djelinek removed the good-first-issue Good for newcomers label Nov 20, 2023
@djelinek djelinek modified the milestones: NEXT, BACKLOG Nov 20, 2023
@djelinek
Copy link
Collaborator

I cannot find out any easy working way how to do that at least at class level...

@djelinek djelinek modified the milestones: BACKLOG, NEXT Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
ExTester
Status: Backlog
Milestone
BACKLOG
Development

No branches or pull requests
3 participants
@djelinek @mlorinc @goverdhan07