Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rm over deprecated rmdir #96

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbpratt
Copy link

@jbpratt jbpratt commented Mar 21, 2024

Description

use rm instead of rmdir

this was officially deprecated in v16

(node:23073) [DEP0147] DeprecationWarning: In future versions of
Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use
fs.rm(path, { recursive: true }) instead

https://nodejs.org/api/deprecations.html#DEP0147

Signed-off-by: jbpratt jbpratt78@gmail.com

Related Issue(s)

fixes #84

Checklist

  • This PR includes a documentation change
  • This PR does not need a documentation change

  • This PR includes test changes
  • This PR's changes are already tested

  • This change is not user-facing
  • This change is a patch change
  • This change is a minor change
  • This change is a major (breaking) change

Changes made

fix deprecation

this was officially deprecated in v16

```
(node:23073) [DEP0147] DeprecationWarning: In future versions of
Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use
fs.rm(path, { recursive: true }) instead
```

https://nodejs.org/api/deprecations.html#DEP0147

Signed-off-by: jbpratt <jbpratt78@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Deprecation warning
1 participant