Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] redhat-actions/oc-login using deprecated version of Node.js #25

Closed
nsalfos opened this issue Oct 14, 2022 · 7 comments
Closed

[BUG] redhat-actions/oc-login using deprecated version of Node.js #25

nsalfos opened this issue Oct 14, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@nsalfos
Copy link

nsalfos commented Oct 14, 2022

Version

redhat-actions/oc-login@v1.1.2

Describe the bug

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: redhat-actions/openshift-tools-installer, redhat-actions/oc-login

Steps to reproduce, workflow links, screenshots

Any attempt to use the actions should show this warning.
I already reported in 2 other actions that apparently also used deprecated versions of Node.js. here & here

@nsalfos nsalfos added the bug Something isn't working label Oct 14, 2022
@smlgbl
Copy link
Contributor

smlgbl commented Nov 1, 2022

I created PR #26 for this.

@ssuganth
Copy link

@smlgbl - Do you know who needs to approve this PR to get merged?

@ssuganth
Copy link

ssuganth commented Nov 16, 2022

@tetchel @divyansh42 - Can someone pls look into this issue?

image

@smlgbl
Copy link
Contributor

smlgbl commented Nov 18, 2022

@smlgbl - Do you know who needs to approve this PR to get merged?

No, sorry. Maybe redhat doesn't care :(
You could use my fork in the meantime.

@chrispoupart
Copy link

Was really hoping to see this resolved by now as well.

Speak to your Red Hat reps and ask them to help bring it to the maintainer's attention.

@smlgbl
Copy link
Contributor

smlgbl commented Dec 23, 2022

PR #26 has been merged! Yay!

@divyansh42
Copy link
Member

Action has been updated to use Node16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants