{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":219598318,"defaultBranch":"master","name":"baseplate.go","ownerLogin":"reddit","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2019-11-04T21:16:51.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/14248?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716582237.0","currentOid":""},"activityList":{"items":[{"before":"8e882273f50250a11a43d4badaeec23f65e97fa9","after":null,"ref":"refs/heads/clientpool-get-after-close-error","pushedAt":"2024-05-24T20:23:57.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"}},{"before":"2a4cb03283d3173da9fc274c995e65337a693264","after":"b7dafe21f531f88b819628e1c4de3a3e36208887","ref":"refs/heads/master","pushedAt":"2024-05-24T20:23:53.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"clientpool: Check Get after Close and return appropriate error\n\nCurrently, when Get is Called after Close, we'll just get a nil client\nfrom the pool and the next `c.IsOpen` check will just panic, which makes\nit very hard to debug why. Add a check to return an appropriate error.","shortMessageHtmlLink":"clientpool: Check Get after Close and return appropriate error"}},{"before":"eec80c87afbb4689616d544b346dc996f9693be6","after":"8e882273f50250a11a43d4badaeec23f65e97fa9","ref":"refs/heads/clientpool-get-after-close-error","pushedAt":"2024-05-24T18:37:21.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"clientpool: Check Get after Close and return appropriate error\n\nCurrently, when Get is Called after Close, we'll just get a nil client\nfrom the pool and the next `c.IsOpen` check will just panic, which makes\nit very hard to debug why. Add a check to return an appropriate error.","shortMessageHtmlLink":"clientpool: Check Get after Close and return appropriate error"}},{"before":"e85e3cddf0b3e11d28f5b767f5fcaacaa26e2410","after":"eec80c87afbb4689616d544b346dc996f9693be6","ref":"refs/heads/clientpool-get-after-close-error","pushedAt":"2024-05-24T18:36:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"clientpool: Check Get after Close and return appropriate error\n\nCurrently, when Get is Called after Close, we'll just get a nil client\nfrom the pool and the next `c.IsOpen` check will just panic, which makes\nit very hard to debug why. Add a check to return an appropriate error.","shortMessageHtmlLink":"clientpool: Check Get after Close and return appropriate error"}},{"before":null,"after":"e85e3cddf0b3e11d28f5b767f5fcaacaa26e2410","ref":"refs/heads/clientpool-get-after-close-error","pushedAt":"2024-05-24T18:31:14.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"clientpool: Check Get after Close and return appropriate error\n\nCurrently, when Get is Called after Close, we'll just get a nil client\nfrom the pool and the next `c.IsOpen` check will just panic, which makes\nit very hard to debug why. Add a check to return an appropriate error.","shortMessageHtmlLink":"clientpool: Check Get after Close and return appropriate error"}},{"before":"d04f7ff29242fde8123e2484c9b51a2f4adcf928","after":null,"ref":"refs/heads/filewatcher-v2-users","pushedAt":"2024-05-24T17:45:04.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"}},{"before":"622dd70750cc1b64e561958af4c8a23f43e8878b","after":"2a4cb03283d3173da9fc274c995e65337a693264","ref":"refs/heads/master","pushedAt":"2024-05-24T17:45:01.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"experiments: Switch to filewatcher/v2\n\nNote: secrets package is not switching because\nfilewatcher.MockFileWatcher is part of its API so switching to v2 will\nbe a breaking change for secrets package.","shortMessageHtmlLink":"experiments: Switch to filewatcher/v2"}},{"before":"f0e1ee2dc3fbb65ede0b6ee79326769d2265f01e","after":"d04f7ff29242fde8123e2484c9b51a2f4adcf928","ref":"refs/heads/filewatcher-v2-users","pushedAt":"2024-05-24T17:39:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"experiments: Switch to filewatcher/v2\n\nNote: secrets package is not switching because\nfilewatcher.MockFileWatcher is part of its API so switching to v2 will\nbe a breaking change for secrets package.","shortMessageHtmlLink":"experiments: Switch to filewatcher/v2"}},{"before":"4eee1145b8904070c658c9a1241d6a4d62569971","after":null,"ref":"refs/heads/filewatcher-v2","pushedAt":"2024-05-24T17:39:13.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"}},{"before":"f1ad2b4e3e84f1c7043ea8d70a6fdb2f230630b6","after":"622dd70750cc1b64e561958af4c8a23f43e8878b","ref":"refs/heads/master","pushedAt":"2024-05-24T17:39:09.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Add filewatcher/v2\n\nBeing the first lib implemented in baseplate.go and long predates\ngenerics, the API of filewatcher lacks type safety and can cause other\nannoyances.\n\nAdd filewatcher/v2 that provides:\n\n* Generics/type safety\n* Use io.Closer over Stop()\n* Use With- options over a Config struct\n* Use slog at error level over log wrapper\n\nAnd change original filewatcher lib to a thin wrapper of v2.\n\nAlso add filewatcher/v2/fwtest and move the fakes there.\n\nThis change intentionally does not change any of its users (experiments,\nsecrets, etc.), as a proof that we did not break v0 API. The next change\nwill switch them to use v2.","shortMessageHtmlLink":"Add filewatcher/v2"}},{"before":"8cbcadc2fadd1766d498c84f7fb73de0587a59ec","after":"f0e1ee2dc3fbb65ede0b6ee79326769d2265f01e","ref":"refs/heads/filewatcher-v2-users","pushedAt":"2024-05-24T16:43:35.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"experiments: Switch to filewatcher/v2\n\nNote: secrets package is not switching because\nfilewatcher.MockFileWatcher is part of its API so switching to v2 will\nbe a breaking change for secrets package.","shortMessageHtmlLink":"experiments: Switch to filewatcher/v2"}},{"before":"68797d19275458814f2c0895cac50118330edd35","after":"4eee1145b8904070c658c9a1241d6a4d62569971","ref":"refs/heads/filewatcher-v2","pushedAt":"2024-05-24T16:43:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Add filewatcher/v2\n\nBeing the first lib implemented in baseplate.go and long predates\ngenerics, the API of filewatcher lacks type safety and can cause other\nannoyances.\n\nAdd filewatcher/v2 that provides:\n\n* Generics/type safety\n* Use io.Closer over Stop()\n* Use With- options over a Config struct\n* Use slog at error level over log wrapper\n\nAnd change original filewatcher lib to a thin wrapper of v2.\n\nAlso add filewatcher/v2/fwtest and move the fakes there.\n\nThis change intentionally does not change any of its users (experiments,\nsecrets, etc.), as a proof that we did not break v0 API. The next change\nwill switch them to use v2.","shortMessageHtmlLink":"Add filewatcher/v2"}},{"before":"66ec8cdcc1dabc888e4cdb3175ecff6f6f7bdf56","after":"8cbcadc2fadd1766d498c84f7fb73de0587a59ec","ref":"refs/heads/filewatcher-v2-users","pushedAt":"2024-05-24T16:41:32.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"experiments: Switch to filewatcher/v2\n\nNote: secrets package is not switching because\nfilewatcher.MockFileWatcher is part of its API so switching to v2 will\nbe a breaking change for secrets package.","shortMessageHtmlLink":"experiments: Switch to filewatcher/v2"}},{"before":"cdae5add9913d2e11f4ab801d5dfaa9bbfe36ef1","after":"68797d19275458814f2c0895cac50118330edd35","ref":"refs/heads/filewatcher-v2","pushedAt":"2024-05-24T16:40:58.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Add filewatcher/v2\n\nBeing the first lib implemented in baseplate.go and long predates\ngenerics, the API of filewatcher lacks type safety and can cause other\nannoyances.\n\nAdd filewatcher/v2 that provides:\n\n* Generics/type safety\n* Use io.Closer over Stop()\n* Use With- options over a Config struct\n* Use slog at error level over log wrapper\n\nAnd change original filewatcher lib to a thin wrapper of v2.\n\nAlso add filewatcher/v2/fwtest and move the fakes there.\n\nThis change intentionally does not change any of its users (experiments,\nsecrets, etc.), as a proof that we did not break v0 API. The next change\nwill switch them to use v2.","shortMessageHtmlLink":"Add filewatcher/v2"}},{"before":"df7d1547d10fedb3ed94cd55f288504390b227fd","after":"66ec8cdcc1dabc888e4cdb3175ecff6f6f7bdf56","ref":"refs/heads/filewatcher-v2-users","pushedAt":"2024-05-24T16:34:27.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"experiments: Switch to filewatcher/v2\n\nNote: secrets package is not switching because\nfilewatcher.MockFileWatcher is part of its API so switching to v2 will\nbe a breaking change for secrets package.","shortMessageHtmlLink":"experiments: Switch to filewatcher/v2"}},{"before":"86a36cc579d716228601e4b7cd8aa26f0b6a3359","after":"cdae5add9913d2e11f4ab801d5dfaa9bbfe36ef1","ref":"refs/heads/filewatcher-v2","pushedAt":"2024-05-24T16:34:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Add filewatcher/v2\n\nBeing the first lib implemented in baseplate.go and long predates\ngenerics, the API of filewatcher lacks type safety and can cause other\nannoyances.\n\nAdd filewatcher/v2 that provides:\n\n* Generics/type safety\n* Use io.Closer over Stop()\n* Use With- options over a Config struct\n* Use slog at error level over log wrapper\n\nAnd change original filewatcher lib to a thin wrapper of v2.\n\nAlso add filewatcher/v2/fwtest and move the fakes there.\n\nThis change intentionally does not change any of its users (experiments,\nsecrets, etc.), as a proof that we did not break v0 API. The next change\nwill switch them to use v2.","shortMessageHtmlLink":"Add filewatcher/v2"}},{"before":"52168a35f8ed6bf7a564d15fcc89c65104a9b1d8","after":"df7d1547d10fedb3ed94cd55f288504390b227fd","ref":"refs/heads/filewatcher-v2-users","pushedAt":"2024-05-24T16:08:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"experiments: Switch to filewatcher/v2\n\nNote: secrets package is not switching because\nfilewatcher.MockFileWatcher is part of its API so switching to v2 will\nbe a breaking change for secrets package.","shortMessageHtmlLink":"experiments: Switch to filewatcher/v2"}},{"before":"66a43a8453b6e6902b713d27e8416d3722bbd852","after":"86a36cc579d716228601e4b7cd8aa26f0b6a3359","ref":"refs/heads/filewatcher-v2","pushedAt":"2024-05-24T16:07:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Add filewatcher/v2\n\nBeing the first lib implemented in baseplate.go and long predates\ngenerics, the API of filewatcher lacks type safety and can cause other\nannoyances.\n\nAdd filewatcher/v2 that provides:\n\n* Generics/type safety\n* Use io.Closer over Stop()\n* Use With- options over a Config struct\n* Use slog at error level over log wrapper\n\nAnd change original filewatcher lib to a thin wrapper of v2.\n\nAlso add filewatcher/v2/fwtest and move the fakes there.\n\nThis change intentionally does not change any of its users (experiments,\nsecrets, etc.), as a proof that we did not break v0 API. The next change\nwill switch them to use v2.","shortMessageHtmlLink":"Add filewatcher/v2"}},{"before":"f23d5947ea04bbb06a4a895b6031ab24d4005475","after":"66a43a8453b6e6902b713d27e8416d3722bbd852","ref":"refs/heads/filewatcher-v2","pushedAt":"2024-05-23T17:43:22.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Fixup","shortMessageHtmlLink":"Fixup"}},{"before":"126d45bc061319066570f418b9b692ea7944d9e4","after":"f23d5947ea04bbb06a4a895b6031ab24d4005475","ref":"refs/heads/filewatcher-v2","pushedAt":"2024-05-23T17:36:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Fixup","shortMessageHtmlLink":"Fixup"}},{"before":null,"after":"52168a35f8ed6bf7a564d15fcc89c65104a9b1d8","ref":"refs/heads/filewatcher-v2-users","pushedAt":"2024-05-22T23:14:37.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"experiments: Switch to filewatcher/v2\n\nNote: secrets package is not switching because\nfilewatcher.MockFileWatcher is part of its API so switching to v2 will\nbe a breaking change for secrets package.","shortMessageHtmlLink":"experiments: Switch to filewatcher/v2"}},{"before":null,"after":"126d45bc061319066570f418b9b692ea7944d9e4","ref":"refs/heads/filewatcher-v2","pushedAt":"2024-05-22T23:05:41.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Add filewatcher/v2\n\nBeing the first lib implemented in baseplate.go and long predates\ngenerics, the API of filewatcher lacks type safety and can cause other\nannoyances.\n\nAdd filewatcher/v2 that provides:\n\n* Generics/type safety\n* Use io.Closer over Stop()\n* Use With- options over a Config struct\n* Use slog at error level over log wrapper\n\nAnd change original filewatcher lib to a thin wrapper of v2.\n\nThis change intentionally does not change any of its users (experiments,\nsecrets, etc.), as a proof that we did not break v0 API. The next change\nwill switch them to use v2.","shortMessageHtmlLink":"Add filewatcher/v2"}},{"before":"73306e54a548fe329cca6d2ad098957df6ff24bf","after":null,"ref":"refs/heads/thriftbp-cleanups","pushedAt":"2024-05-09T15:31:06.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"}},{"before":"25e0999cef443f81e4d60dadc9d7962e4da08898","after":"f1ad2b4e3e84f1c7043ea8d70a6fdb2f230630b6","ref":"refs/heads/master","pushedAt":"2024-05-09T15:31:02.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"thriftbp: Deprecate ServerConfig.ReportPayloadSizeMetricsSampleRate\n\nWe marked\nDefaultProcessorMiddlewaresArgs.ReportPayloadSizeMetricsSampleRate as\ndeprecated in a previous PR, but forgot to also mark\nServerConfig.ReportPayloadSizeMetricsSampleRate as deprecated.","shortMessageHtmlLink":"thriftbp: Deprecate ServerConfig.ReportPayloadSizeMetricsSampleRate"}},{"before":"3f8894536e9b0fedf04097020db614de6c65e688","after":"da055b9d6d4990c3be213e29f6b3a73965a0720c","ref":"refs/heads/use-global-tracer","pushedAt":"2024-05-08T19:22:12.000Z","pushType":"push","commitsCount":19,"pusher":{"login":"redloaf","name":null,"path":"/redloaf","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/99754113?s=80&v=4"},"commit":{"message":"add comment about globalTracer usage","shortMessageHtmlLink":"add comment about globalTracer usage"}},{"before":"036846f6185d1a8cc800286c138006fa665b1084","after":"73306e54a548fe329cca6d2ad098957df6ff24bf","ref":"refs/heads/thriftbp-cleanups","pushedAt":"2024-05-08T18:04:46.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"thriftbp: Deprecate ServerConfig.ReportPayloadSizeMetricsSampleRate\n\nWe marked\nDefaultProcessorMiddlewaresArgs.ReportPayloadSizeMetricsSampleRate as\ndeprecated in a previous PR, but forgot to also mark\nServerConfig.ReportPayloadSizeMetricsSampleRate as deprecated.","shortMessageHtmlLink":"thriftbp: Deprecate ServerConfig.ReportPayloadSizeMetricsSampleRate"}},{"before":null,"after":"036846f6185d1a8cc800286c138006fa665b1084","ref":"refs/heads/thriftbp-cleanups","pushedAt":"2024-05-08T18:03:47.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"thriftbp: Deprecate ServerConfig.ReportPayloadSizeMetricsSampleRate\n\nWe marked\nDefaultProcessorMiddlewaresArgs.ReportPayloadSizeMetricsSampleRate as\ndeprecated in a previous PR, but forgot to also mark\nServerConfig.ReportPayloadSizeMetricsSampleRate as deprecated.","shortMessageHtmlLink":"thriftbp: Deprecate ServerConfig.ReportPayloadSizeMetricsSampleRate"}},{"before":"99a00abf70ece47fe19948086c9e57ef491d434c","after":null,"ref":"refs/heads/thriftbp-fix-bug","pushedAt":"2024-05-07T21:03:18.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"}},{"before":"4ae1e53b9575ceae74cf026bd45f58fa7e636fb3","after":"25e0999cef443f81e4d60dadc9d7962e4da08898","ref":"refs/heads/master","pushedAt":"2024-05-07T21:03:15.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"thriftbp: Fix a bug caused by bad merge from the previous PR\n\nDue to a bad merge between the previous 2 PRs, we are not really using\nthe countingDelegateTransport in the client created by client pool, so\nthe bytes are not counting and we always report 0 as the bytes\nread/written.\n\nRename the args inside newClient generator to fix the bug.","shortMessageHtmlLink":"thriftbp: Fix a bug caused by bad merge from the previous PR"}},{"before":"c304d6182c85bde83736ff885b2ac481bfe066f6","after":"99a00abf70ece47fe19948086c9e57ef491d434c","ref":"refs/heads/thriftbp-fix-bug","pushedAt":"2024-05-07T20:29:21.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"thriftbp: Fix a bug caused by bad merge from the previous PR\n\nDue to a bad merge between the previous 2 PRs, we are not really using\nthe countingDelegateTransport in the client created by client pool, so\nthe bytes are not counting and we always report 0 as the bytes\nread/written.\n\nRename the args inside newClient generator to fix the bug.","shortMessageHtmlLink":"thriftbp: Fix a bug caused by bad merge from the previous PR"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEU2HD0wA","startCursor":null,"endCursor":null}},"title":"Activity · reddit/baseplate.go"}