Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happened to ReplaceAssertArraySubsetRector.php? #8614

Closed
eelkeblok opened this issue Apr 27, 2024 · 3 comments
Closed

What happened to ReplaceAssertArraySubsetRector.php? #8614

eelkeblok opened this issue Apr 27, 2024 · 3 comments

Comments

@eelkeblok
Copy link

eelkeblok commented Apr 27, 2024

I hope somebody can shed some light on my confusion. I'm trying to use Rector for a conversion/update of a bunch of tests. I ran into the use of assertArraySubset and was happy to find #1025. However, looking in the current codebase, I can't seem to find this. Am I looking in the wrong place, was it removed on purpose, or was it overlooked during some refactoring (as the project structure seems quite different from then)?

Thanks for any insight you might have.

@eelkeblok
Copy link
Author

eelkeblok commented Apr 27, 2024

It got removed here: #4611. Haven't found where its replacement (the polyfill) went.

@eelkeblok
Copy link
Author

eelkeblok commented Apr 28, 2024

So it did make it to the separate PHPUnit package. #5905

@eelkeblok
Copy link
Author

Right. So there... rectorphp/rector-phpunit#222. Not looking forward to handle all these cases manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant