Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is rector-prefixed still maintained? #801

Closed
soullivaneuh opened this issue Nov 30, 2018 · 10 comments
Closed

Is rector-prefixed still maintained? #801

soullivaneuh opened this issue Nov 30, 2018 · 10 comments

Comments

@soullivaneuh
Copy link
Contributor

It is indicated that release are automatic. But I see only one release and the master branch is way later than this one.

BTW, why asking to install the prefixed with dev-master version?

@soullivaneuh
Copy link
Contributor Author

I tried using composer bin to install rector, but I still have weird issues like this:

vendor/bin/rector process src src-dev tests --level php70 -vvv

Fatal error: Declaration of Rector\Php\Rector\FunctionLike\ExceptionHandlerTypehintRector::refactor(Rector\Php\Rector\FunctionLike\Node $node): ?Rector\Php\Rector\FunctionLike\Node must be compatible with Rector\Contract\Rector\PhpRectorInterface::refactor(PhpParser\Node $node): ?PhpParser\Node in /code/vendor-bin/rector/vendor/rector/rector/packages/Php/src/Rector/FunctionLike/ExceptionHandlerTypehintRector.php on line 72

@TomasVotruba
Copy link
Member

TomasVotruba commented Nov 30, 2018

It actually needs a maintainer who uses it and is able to fix that. I'm not able to, since I don't use it.

I tried using composer bin to install rector, but I still have weird issues like this:

That's not recomended. The only working solution can be Rector build with: https://github.com/rectorphp/prefixer

It needs fixes by someone who use it though.

@soullivaneuh
Copy link
Contributor Author

Did you give a try to https://github.com/humbug/php-scoper ?

This allow you to provide a .phar with always auto-prefix without more maintenance.

See also sebastianbergmann/phpunit#2015

@TomasVotruba
Copy link
Member

@soullivaneuh
Copy link
Contributor Author

I didn't, booh one me. :-(

@TomasVotruba
Copy link
Member

Anyway, if you'd like to help with that, I'd prepare a README with what I know and how the build should work.

@soullivaneuh
Copy link
Contributor Author

I have to find some free-time. But in anyway, the documentation would be welcome for me or anyone else. 😉

@TomasVotruba
Copy link
Member

Of course, it would just increase motivation knowing it will be used right away 😄

@TomasVotruba
Copy link
Member

Closing as answered

@TomasVotruba
Copy link
Member

We have working version now 👍

See https://github.com/rectorphp/rector-prefixed

echo511 pushed a commit to echo511/rector that referenced this issue Sep 4, 2021
…veAlwaysElseRector (rectorphp#807)

* added failing test fixture

* update

* update

* Closes rectorphp#801 Fixes rectorphp#6670

Co-authored-by: Bl00D4NGEL <kuhlesdominik@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants