From 0123b4277c46b893e0b9955537269836c66fdcdd Mon Sep 17 00:00:00 2001
From: Tommy Quissens <tommy.quissens@storefront.be>
Date: Tue, 22 Sep 2020 15:59:51 +0200
Subject: [PATCH] [Downgrade PHP 7.3] Trailing commas in function calls

---
 config/set/downgrade-php73.php                |  3 +-
 ...DowngradeTrailingCommasInFunctionCalls.php | 63 +++++++++++++++++
 .../DowngradeFlexibleHeredocSyntax.php        | 70 -------------------
 ...gradeTrailingCommasInFunctionCallsTest.php | 40 +++++++++++
 .../Fixture/fixture.php.inc                   | 27 +++++++
 .../DowngradeFlexibleHeredocSyntaxTest.php    | 31 --------
 .../Fixture/fixture.php.inc                   | 35 ----------
 7 files changed, 131 insertions(+), 138 deletions(-)
 create mode 100644 rules/downgrade-php73/src/Rector/FuncCall/DowngradeTrailingCommasInFunctionCalls.php
 delete mode 100644 rules/downgrade-php73/src/Rector/String_/DowngradeFlexibleHeredocSyntax.php
 create mode 100644 rules/downgrade-php73/tests/Rector/FuncCall/DowngradeTrailingCommasInFunctionCalls/DowngradeTrailingCommasInFunctionCallsTest.php
 create mode 100644 rules/downgrade-php73/tests/Rector/FuncCall/DowngradeTrailingCommasInFunctionCalls/Fixture/fixture.php.inc
 delete mode 100644 rules/downgrade-php73/tests/Rector/String_/DowngradeFlexibleHeredocSyntax/DowngradeFlexibleHeredocSyntaxTest.php
 delete mode 100644 rules/downgrade-php73/tests/Rector/String_/DowngradeFlexibleHeredocSyntax/Fixture/fixture.php.inc

diff --git a/config/set/downgrade-php73.php b/config/set/downgrade-php73.php
index d64935ca0da..2a4afdbd62b 100644
--- a/config/set/downgrade-php73.php
+++ b/config/set/downgrade-php73.php
@@ -3,10 +3,9 @@
 declare(strict_types=1);
 
 use Rector\DowngradePhp73\Rector\FuncCall\DowngradeTrailingCommasInFunctionCalls;
-use Rector\DowngradePhp73\Rector\String_\DowngradeFlexibleHeredocSyntax;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 
 return static function (ContainerConfigurator $containerConfigurator): void {
     $services = $containerConfigurator->services();
-    $services->set(DowngradeFlexibleHeredocSyntax::class);
+    $services->set(DowngradeTrailingCommasInFunctionCalls::class);
 };
diff --git a/rules/downgrade-php73/src/Rector/FuncCall/DowngradeTrailingCommasInFunctionCalls.php b/rules/downgrade-php73/src/Rector/FuncCall/DowngradeTrailingCommasInFunctionCalls.php
new file mode 100644
index 00000000000..4b484cfac5c
--- /dev/null
+++ b/rules/downgrade-php73/src/Rector/FuncCall/DowngradeTrailingCommasInFunctionCalls.php
@@ -0,0 +1,63 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\DowngradePhp73\Rector\FuncCall;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\FuncCall;
+use Rector\Core\Rector\AbstractRector;
+use Rector\Core\RectorDefinition\CodeSample;
+use Rector\Core\RectorDefinition\RectorDefinition;
+use Rector\NodeTypeResolver\Node\AttributeKey;
+
+final class DowngradeTrailingCommasInFunctionCalls extends AbstractRector
+{
+    public function getDefinition(): RectorDefinition
+    {
+        return new RectorDefinition(
+            'Remove trailing commas in function calls', [
+                new CodeSample(
+                    <<<'CODE_SAMPLE'
+class SomeClass
+{
+    public function __construct(string $value)
+    {
+        $compacted = compact(
+            'posts',
+            'units',
+        );
+    }
+}
+CODE_SAMPLE
+                    , <<<'CODE_SAMPLE'
+class SomeClass
+{
+    public function __construct(string $value)
+    {
+        $compacted = compact(
+            'posts',
+            'units'
+        );
+    }
+}
+CODE_SAMPLE
+                ),
+            ]
+        );
+    }
+
+    /**
+     * @return string[]
+     */
+    public function getNodeTypes(): array
+    {
+        return [FuncCall::class];
+    }
+
+    public function refactor(Node $node): ?Node
+    {
+        $node->setAttribute(AttributeKey::ORIGINAL_NODE, null);
+        return $node;
+    }
+}
diff --git a/rules/downgrade-php73/src/Rector/String_/DowngradeFlexibleHeredocSyntax.php b/rules/downgrade-php73/src/Rector/String_/DowngradeFlexibleHeredocSyntax.php
deleted file mode 100644
index fadd5a45ff8..00000000000
--- a/rules/downgrade-php73/src/Rector/String_/DowngradeFlexibleHeredocSyntax.php
+++ /dev/null
@@ -1,70 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Rector\DowngradePhp73\Rector\String_;
-
-use PhpParser\Node;
-use PhpParser\Node\Scalar\String_;
-use Rector\Core\Rector\AbstractRector;
-use Rector\Core\RectorDefinition\CodeSample;
-use Rector\Core\RectorDefinition\RectorDefinition;
-use Rector\NodeTypeResolver\Node\AttributeKey;
-
-/**
- * @see https://wiki.php.net/rfc/flexible_heredoc_nowdoc_syntaxes
- * @see \Rector\Php73\Tests\Rector\String_\SensitiveHereNowDocRector\SensitiveHereNowDocRectorTest
- */
-final class DowngradeFlexibleHeredocSyntax extends AbstractRector
-{
-    /**
-     * @var string
-     */
-    private const WRAP_SUFFIX = '_WRAP';
-
-    public function getDefinition(): RectorDefinition
-    {
-        return new RectorDefinition('Changes heredoc/nowdoc that contains closing word to safe wrapper name', [
-            new CodeSample(
-                <<<'CODE_SAMPLE'
-$query = <<<SQL
-    SELECT *
-    FROM `table`
-    WHERE `column` = true;
-    SQL;
-CODE_SAMPLE
-                ,
-                <<<'CODE_SAMPLE'
-$query = <<<SQL
-SELECT *
-FROM `table`
-WHERE `column` = true;
-SQL;
-CODE_SAMPLE
-            ),
-        ]);
-    }
-
-    /**
-     * @return string[]
-     */
-    public function getNodeTypes(): array
-    {
-        return [String_::class];
-    }
-
-    /**
-     * @param String_ $node
-     */
-    public function refactor(Node $node): ?Node
-    {
-        if (! in_array($node->getAttribute(AttributeKey::KIND), [String_::KIND_HEREDOC, String_::KIND_NOWDOC], true)) {
-            return null;
-        }
-
-        $node->setAttribute('docIndentation', '');
-        $node->setAttribute(AttributeKey::ORIGINAL_NODE, null);
-
-        return $node;
-    }
-}
diff --git a/rules/downgrade-php73/tests/Rector/FuncCall/DowngradeTrailingCommasInFunctionCalls/DowngradeTrailingCommasInFunctionCallsTest.php b/rules/downgrade-php73/tests/Rector/FuncCall/DowngradeTrailingCommasInFunctionCalls/DowngradeTrailingCommasInFunctionCallsTest.php
new file mode 100644
index 00000000000..eeec4cf7ec9
--- /dev/null
+++ b/rules/downgrade-php73/tests/Rector/FuncCall/DowngradeTrailingCommasInFunctionCalls/DowngradeTrailingCommasInFunctionCallsTest.php
@@ -0,0 +1,40 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\DowngradePhp73\Tests\Rector\FuncCall\DowngradeTrailingCommasInFunctionCalls;
+
+use Iterator;
+use Rector\Core\Testing\PHPUnit\AbstractRectorTestCase;
+use Rector\Core\ValueObject\PhpVersionFeature;
+use Rector\DowngradePhp73\Rector\FuncCall\DowngradeTrailingCommasInFunctionCalls;
+use Symplify\SmartFileSystem\SmartFileInfo;
+
+final class DowngradeTrailingCommasInFunctionCallsTest extends AbstractRectorTestCase
+{
+    /**
+     * @requires PHP >= 7.3
+     * @dataProvider provideData()
+     */
+    public function test(SmartFileInfo $fileInfo): void
+    {
+        $this->doTestFileInfo($fileInfo);
+    }
+
+    public function provideData(): Iterator
+    {
+        return $this->yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    protected function getRectorClass(): string
+    {
+        return DowngradeTrailingCommasInFunctionCalls::class;
+    }
+
+    protected function getPhpVersion(): string
+    {
+        return '7.2';
+//        TODO: create constant
+//        return PhpVersionFeature::;
+    }
+}
diff --git a/rules/downgrade-php73/tests/Rector/FuncCall/DowngradeTrailingCommasInFunctionCalls/Fixture/fixture.php.inc b/rules/downgrade-php73/tests/Rector/FuncCall/DowngradeTrailingCommasInFunctionCalls/Fixture/fixture.php.inc
new file mode 100644
index 00000000000..808956bac86
--- /dev/null
+++ b/rules/downgrade-php73/tests/Rector/FuncCall/DowngradeTrailingCommasInFunctionCalls/Fixture/fixture.php.inc
@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\DowngradePhp73\Tests\Rector\FuncCall\DowngradeNullCoalescingOperatorRector\Fixture;
+
+class FixtureClass
+{
+    public function run()
+    {
+        $compacted = compact('posts','units',);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\DowngradePhp73\Tests\Rector\FuncCall\DowngradeNullCoalescingOperatorRector\Fixture;
+
+class FixtureClass
+{
+    public function run()
+    {
+        $compacted = compact('posts', 'units');
+    }
+}
+
+?>
diff --git a/rules/downgrade-php73/tests/Rector/String_/DowngradeFlexibleHeredocSyntax/DowngradeFlexibleHeredocSyntaxTest.php b/rules/downgrade-php73/tests/Rector/String_/DowngradeFlexibleHeredocSyntax/DowngradeFlexibleHeredocSyntaxTest.php
deleted file mode 100644
index e72c2d718f2..00000000000
--- a/rules/downgrade-php73/tests/Rector/String_/DowngradeFlexibleHeredocSyntax/DowngradeFlexibleHeredocSyntaxTest.php
+++ /dev/null
@@ -1,31 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Rector\Php73\Tests\Rector\String_\SensitiveHereNowDocRector;
-
-use Iterator;
-use Rector\Core\Testing\PHPUnit\AbstractRectorTestCase;
-use Rector\DowngradePhp73\Rector\String_\DowngradeFlexibleHeredocSyntax;
-use Symplify\SmartFileSystem\SmartFileInfo;
-
-final class DowngradeFlexibleHeredocSyntaxTest extends AbstractRectorTestCase
-{
-    /**
-     * @dataProvider provideData()
-     */
-    public function test(SmartFileInfo $fileInfo): void
-    {
-        $this->doTestFileInfo($fileInfo);
-    }
-
-    public function provideData(): Iterator
-    {
-        return $this->yieldFilesFromDirectory(__DIR__ . '/Fixture');
-    }
-
-    protected function getRectorClass(): string
-    {
-        return DowngradeFlexibleHeredocSyntax::class;
-    }
-}
diff --git a/rules/downgrade-php73/tests/Rector/String_/DowngradeFlexibleHeredocSyntax/Fixture/fixture.php.inc b/rules/downgrade-php73/tests/Rector/String_/DowngradeFlexibleHeredocSyntax/Fixture/fixture.php.inc
deleted file mode 100644
index 5c6151045cb..00000000000
--- a/rules/downgrade-php73/tests/Rector/String_/DowngradeFlexibleHeredocSyntax/Fixture/fixture.php.inc
+++ /dev/null
@@ -1,35 +0,0 @@
-<?php
-
-namespace Rector\DowngradePhp73\Tests\Rector\FuncCall\DowngradeFlexibleHeredocSyntax\Fixture;
-
-class FixtureClass
-{
-    public function run()
-    {
-        $query = <<<SQL
-        SELECT *
-        FROM `table`
-        WHERE `column` = true;
-        SQL;
-    }
-}
-
-?>
------
-<?php
-
-namespace Rector\DowngradePhp73\Tests\Rector\FuncCall\DowngradeFlexibleHeredocSyntax\Fixture;
-
-class FixtureClass
-{
-    public function run()
-    {
-        $query = <<<SQL
-SELECT *
-FROM `table`
-WHERE `column` = true;
-SQL;
-    }
-}
-
-?>