From efbf03b9c2697338593e6ba388808c476e80e45a Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Sat, 6 Aug 2022 17:11:58 +0200 Subject: [PATCH] Revert Add class-string typehint to MethodCallRename (#2726) This reverts commit f99f19cd4328009bad8aaeab7d80f7d920628bca. --- rules/Arguments/ValueObject/ArgumentAdder.php | 1 - rules/Arguments/ValueObject/RemoveMethodCallParam.php | 3 --- rules/Arguments/ValueObject/ReplaceArgumentDefaultValue.php | 1 - .../DeadCode/ValueObject/BinaryToVersionCompareCondition.php | 3 --- rules/Php80/ValueObject/ClassNameAndTagValueNode.php | 3 --- .../ValueObject/ReplaceStringWithClassConstant.php | 1 - rules/Removing/ValueObject/ArgumentRemover.php | 3 --- rules/Renaming/ValueObject/MethodCallRename.php | 3 --- rules/Renaming/ValueObject/MethodCallRenameWithArrayKey.php | 3 --- rules/Renaming/ValueObject/RenameClassAndConstFetch.php | 4 ---- rules/Renaming/ValueObject/RenameClassConstFetch.php | 3 --- rules/Renaming/ValueObject/RenameStaticMethod.php | 4 ---- rules/Transform/ValueObject/ArgumentFuncCallToMethodCall.php | 3 --- rules/Transform/ValueObject/ArrayFuncCallToMethodCall.php | 2 +- rules/Transform/ValueObject/AttributeKeyToClassConstFetch.php | 2 -- rules/Transform/ValueObject/DimFetchAssignToMethodCall.php | 4 ---- rules/Transform/ValueObject/MethodCallToStaticCall.php | 4 ---- rules/Transform/ValueObject/NewToStaticCall.php | 3 --- rules/Transform/ValueObject/PropertyAssignToMethodCall.php | 3 --- .../Transform/ValueObject/ReplaceParentCallByPropertyCall.php | 3 --- rules/Transform/ValueObject/StaticCallToFuncCall.php | 3 --- rules/Transform/ValueObject/StaticCallToMethodCall.php | 3 --- rules/Transform/ValueObject/StaticCallToNew.php | 3 --- rules/Transform/ValueObject/StringToClassConstant.php | 3 --- .../ValueObject/AddPropertyTypeDeclaration.php | 3 --- .../TypeDeclaration/ValueObject/AddReturnTypeDeclaration.php | 3 --- rules/Visibility/ValueObject/ChangeConstantVisibility.php | 3 --- rules/Visibility/ValueObject/ChangeMethodVisibility.php | 3 --- 28 files changed, 1 insertion(+), 79 deletions(-) diff --git a/rules/Arguments/ValueObject/ArgumentAdder.php b/rules/Arguments/ValueObject/ArgumentAdder.php index 32a8546786a..22cbbdbb2af 100644 --- a/rules/Arguments/ValueObject/ArgumentAdder.php +++ b/rules/Arguments/ValueObject/ArgumentAdder.php @@ -11,7 +11,6 @@ final class ArgumentAdder { /** - * @param class-string $class * @param mixed|null $argumentDefaultValue */ public function __construct( diff --git a/rules/Arguments/ValueObject/RemoveMethodCallParam.php b/rules/Arguments/ValueObject/RemoveMethodCallParam.php index 535d8c53338..e30418271ba 100644 --- a/rules/Arguments/ValueObject/RemoveMethodCallParam.php +++ b/rules/Arguments/ValueObject/RemoveMethodCallParam.php @@ -8,9 +8,6 @@ final class RemoveMethodCallParam { - /** - * @param class-string $class - */ public function __construct( private readonly string $class, private readonly string $methodName, diff --git a/rules/Arguments/ValueObject/ReplaceArgumentDefaultValue.php b/rules/Arguments/ValueObject/ReplaceArgumentDefaultValue.php index 9623c9718ed..79546e043c2 100644 --- a/rules/Arguments/ValueObject/ReplaceArgumentDefaultValue.php +++ b/rules/Arguments/ValueObject/ReplaceArgumentDefaultValue.php @@ -16,7 +16,6 @@ final class ReplaceArgumentDefaultValue implements ReplaceArgumentDefaultValueIn public const ANY_VALUE_BEFORE = '*ANY_VALUE_BEFORE*'; /** - * @param class-string $class * @param int<0, max> $position */ public function __construct( diff --git a/rules/DeadCode/ValueObject/BinaryToVersionCompareCondition.php b/rules/DeadCode/ValueObject/BinaryToVersionCompareCondition.php index dc1a51a3365..49c94cca0b8 100644 --- a/rules/DeadCode/ValueObject/BinaryToVersionCompareCondition.php +++ b/rules/DeadCode/ValueObject/BinaryToVersionCompareCondition.php @@ -8,9 +8,6 @@ final class BinaryToVersionCompareCondition implements ConditionInterface { - /** - * @param class-string $binaryClass - */ public function __construct( private readonly VersionCompareCondition $versionCompareCondition, private readonly string $binaryClass, diff --git a/rules/Php80/ValueObject/ClassNameAndTagValueNode.php b/rules/Php80/ValueObject/ClassNameAndTagValueNode.php index 0616d56b94e..a958ee223d0 100644 --- a/rules/Php80/ValueObject/ClassNameAndTagValueNode.php +++ b/rules/Php80/ValueObject/ClassNameAndTagValueNode.php @@ -10,9 +10,6 @@ final class ClassNameAndTagValueNode { - /** - * @param class-string $enumClass - */ public function __construct( private readonly string $enumClass, private readonly ParamTagValueNode|ReturnTagValueNode|VarTagValueNode $tagValueNode diff --git a/rules/Privatization/ValueObject/ReplaceStringWithClassConstant.php b/rules/Privatization/ValueObject/ReplaceStringWithClassConstant.php index 3e9a8bb1e3c..5cf3f7a1050 100644 --- a/rules/Privatization/ValueObject/ReplaceStringWithClassConstant.php +++ b/rules/Privatization/ValueObject/ReplaceStringWithClassConstant.php @@ -10,7 +10,6 @@ final class ReplaceStringWithClassConstant { /** - * @param class-string $class * @param class-string $classWithConstants */ public function __construct( diff --git a/rules/Removing/ValueObject/ArgumentRemover.php b/rules/Removing/ValueObject/ArgumentRemover.php index bf0c4059204..e4596ec9366 100644 --- a/rules/Removing/ValueObject/ArgumentRemover.php +++ b/rules/Removing/ValueObject/ArgumentRemover.php @@ -9,9 +9,6 @@ final class ArgumentRemover { - /** - * @param class-string $class - */ public function __construct( private readonly string $class, private readonly string $method, diff --git a/rules/Renaming/ValueObject/MethodCallRename.php b/rules/Renaming/ValueObject/MethodCallRename.php index f7ccf1f8b8c..eb0c20d659d 100644 --- a/rules/Renaming/ValueObject/MethodCallRename.php +++ b/rules/Renaming/ValueObject/MethodCallRename.php @@ -10,9 +10,6 @@ final class MethodCallRename implements MethodCallRenameInterface { - /** - * @param class-string $class - */ public function __construct( private readonly string $class, private readonly string $oldMethod, diff --git a/rules/Renaming/ValueObject/MethodCallRenameWithArrayKey.php b/rules/Renaming/ValueObject/MethodCallRenameWithArrayKey.php index ba159948435..95870a5d6d6 100644 --- a/rules/Renaming/ValueObject/MethodCallRenameWithArrayKey.php +++ b/rules/Renaming/ValueObject/MethodCallRenameWithArrayKey.php @@ -10,9 +10,6 @@ final class MethodCallRenameWithArrayKey implements MethodCallRenameInterface { - /** - * @param class-string $class - */ public function __construct( private readonly string $class, private readonly string $oldMethod, diff --git a/rules/Renaming/ValueObject/RenameClassAndConstFetch.php b/rules/Renaming/ValueObject/RenameClassAndConstFetch.php index 9c2eafcf3bb..a4753ea12c1 100644 --- a/rules/Renaming/ValueObject/RenameClassAndConstFetch.php +++ b/rules/Renaming/ValueObject/RenameClassAndConstFetch.php @@ -10,10 +10,6 @@ final class RenameClassAndConstFetch implements RenameClassConstFetchInterface { - /** - * @param class-string $oldClass - * @param class-string $newClass - */ public function __construct( private readonly string $oldClass, private readonly string $oldConstant, diff --git a/rules/Renaming/ValueObject/RenameClassConstFetch.php b/rules/Renaming/ValueObject/RenameClassConstFetch.php index b2b596b8a45..b6ce43f349d 100644 --- a/rules/Renaming/ValueObject/RenameClassConstFetch.php +++ b/rules/Renaming/ValueObject/RenameClassConstFetch.php @@ -10,9 +10,6 @@ final class RenameClassConstFetch implements RenameClassConstFetchInterface { - /** - * @param class-string $oldClass - */ public function __construct( private readonly string $oldClass, private readonly string $oldConstant, diff --git a/rules/Renaming/ValueObject/RenameStaticMethod.php b/rules/Renaming/ValueObject/RenameStaticMethod.php index d44cfae0b1d..0a2903d1650 100644 --- a/rules/Renaming/ValueObject/RenameStaticMethod.php +++ b/rules/Renaming/ValueObject/RenameStaticMethod.php @@ -9,10 +9,6 @@ final class RenameStaticMethod { - /** - * @param class-string $oldClass - * @param class-string $newClass - */ public function __construct( private readonly string $oldClass, private readonly string $oldMethod, diff --git a/rules/Transform/ValueObject/ArgumentFuncCallToMethodCall.php b/rules/Transform/ValueObject/ArgumentFuncCallToMethodCall.php index 4997d5dbf34..3707cb8f0ec 100644 --- a/rules/Transform/ValueObject/ArgumentFuncCallToMethodCall.php +++ b/rules/Transform/ValueObject/ArgumentFuncCallToMethodCall.php @@ -9,9 +9,6 @@ final class ArgumentFuncCallToMethodCall implements ArgumentFuncCallToMethodCallInterface { - /** - * @param class-string $class - */ public function __construct( private readonly string $function, private readonly string $class, diff --git a/rules/Transform/ValueObject/ArrayFuncCallToMethodCall.php b/rules/Transform/ValueObject/ArrayFuncCallToMethodCall.php index 4ff68ebd016..e08538d3085 100644 --- a/rules/Transform/ValueObject/ArrayFuncCallToMethodCall.php +++ b/rules/Transform/ValueObject/ArrayFuncCallToMethodCall.php @@ -11,7 +11,7 @@ final class ArrayFuncCallToMethodCall implements ArgumentFuncCallToMethodCallInt { /** * @param non-empty-string $function - * @param class-string $class + * @param non-empty-string $class * @param non-empty-string $arrayMethod * @param non-empty-string $nonArrayMethod */ diff --git a/rules/Transform/ValueObject/AttributeKeyToClassConstFetch.php b/rules/Transform/ValueObject/AttributeKeyToClassConstFetch.php index 3badd23e5a6..9e59515a653 100644 --- a/rules/Transform/ValueObject/AttributeKeyToClassConstFetch.php +++ b/rules/Transform/ValueObject/AttributeKeyToClassConstFetch.php @@ -7,8 +7,6 @@ final class AttributeKeyToClassConstFetch { /** - * @param class-string $attributeClass - * @param class-string $constantClass * @param array $valuesToConstantsMap */ public function __construct( diff --git a/rules/Transform/ValueObject/DimFetchAssignToMethodCall.php b/rules/Transform/ValueObject/DimFetchAssignToMethodCall.php index 4a0b9d13cfe..55a8de4a901 100644 --- a/rules/Transform/ValueObject/DimFetchAssignToMethodCall.php +++ b/rules/Transform/ValueObject/DimFetchAssignToMethodCall.php @@ -9,10 +9,6 @@ final class DimFetchAssignToMethodCall { - /** - * @param class-string $listClass - * @param class-string $itemClass - */ public function __construct( private readonly string $listClass, private readonly string $itemClass, diff --git a/rules/Transform/ValueObject/MethodCallToStaticCall.php b/rules/Transform/ValueObject/MethodCallToStaticCall.php index fa81f7da4ba..271d365975d 100644 --- a/rules/Transform/ValueObject/MethodCallToStaticCall.php +++ b/rules/Transform/ValueObject/MethodCallToStaticCall.php @@ -9,10 +9,6 @@ final class MethodCallToStaticCall { - /** - * @param class-string $oldClass - * @param class-string $newClass - */ public function __construct( private readonly string $oldClass, private readonly string $oldMethod, diff --git a/rules/Transform/ValueObject/NewToStaticCall.php b/rules/Transform/ValueObject/NewToStaticCall.php index 1f6ba4ec46e..3cd30494944 100644 --- a/rules/Transform/ValueObject/NewToStaticCall.php +++ b/rules/Transform/ValueObject/NewToStaticCall.php @@ -9,9 +9,6 @@ final class NewToStaticCall { - /** - * @param class-string $staticCallClass - */ public function __construct( private readonly string $type, private readonly string $staticCallClass, diff --git a/rules/Transform/ValueObject/PropertyAssignToMethodCall.php b/rules/Transform/ValueObject/PropertyAssignToMethodCall.php index 7c4c16ac662..d5c3c0b76db 100644 --- a/rules/Transform/ValueObject/PropertyAssignToMethodCall.php +++ b/rules/Transform/ValueObject/PropertyAssignToMethodCall.php @@ -9,9 +9,6 @@ final class PropertyAssignToMethodCall { - /** - * @param class-string $class - */ public function __construct( private readonly string $class, private readonly string $oldPropertyName, diff --git a/rules/Transform/ValueObject/ReplaceParentCallByPropertyCall.php b/rules/Transform/ValueObject/ReplaceParentCallByPropertyCall.php index 8a2ceff9126..78f23826247 100644 --- a/rules/Transform/ValueObject/ReplaceParentCallByPropertyCall.php +++ b/rules/Transform/ValueObject/ReplaceParentCallByPropertyCall.php @@ -9,9 +9,6 @@ final class ReplaceParentCallByPropertyCall { - /** - * @param class-string $class - */ public function __construct( private readonly string $class, private readonly string $method, diff --git a/rules/Transform/ValueObject/StaticCallToFuncCall.php b/rules/Transform/ValueObject/StaticCallToFuncCall.php index ac6ba51a328..f5e96f6963c 100644 --- a/rules/Transform/ValueObject/StaticCallToFuncCall.php +++ b/rules/Transform/ValueObject/StaticCallToFuncCall.php @@ -9,9 +9,6 @@ final class StaticCallToFuncCall { - /** - * @param class-string $class - */ public function __construct( private readonly string $class, private readonly string $method, diff --git a/rules/Transform/ValueObject/StaticCallToMethodCall.php b/rules/Transform/ValueObject/StaticCallToMethodCall.php index ddb72df0549..e4102e28a70 100644 --- a/rules/Transform/ValueObject/StaticCallToMethodCall.php +++ b/rules/Transform/ValueObject/StaticCallToMethodCall.php @@ -12,9 +12,6 @@ final class StaticCallToMethodCall { - /** - * @param class-string $staticClass - */ public function __construct( private readonly string $staticClass, private readonly string $staticMethod, diff --git a/rules/Transform/ValueObject/StaticCallToNew.php b/rules/Transform/ValueObject/StaticCallToNew.php index befebd599a8..e07fd50a19c 100644 --- a/rules/Transform/ValueObject/StaticCallToNew.php +++ b/rules/Transform/ValueObject/StaticCallToNew.php @@ -8,9 +8,6 @@ final class StaticCallToNew { - /** - * @param class-string $class - */ public function __construct( private readonly string $class, private readonly string $method diff --git a/rules/Transform/ValueObject/StringToClassConstant.php b/rules/Transform/ValueObject/StringToClassConstant.php index 54cb1fe4ecd..48aa8b9ad4e 100644 --- a/rules/Transform/ValueObject/StringToClassConstant.php +++ b/rules/Transform/ValueObject/StringToClassConstant.php @@ -8,9 +8,6 @@ final class StringToClassConstant { - /** - * @param class-string $class - */ public function __construct( private readonly string $string, private readonly string $class, diff --git a/rules/TypeDeclaration/ValueObject/AddPropertyTypeDeclaration.php b/rules/TypeDeclaration/ValueObject/AddPropertyTypeDeclaration.php index 24d7eceaf9d..6b868d4ad37 100644 --- a/rules/TypeDeclaration/ValueObject/AddPropertyTypeDeclaration.php +++ b/rules/TypeDeclaration/ValueObject/AddPropertyTypeDeclaration.php @@ -9,9 +9,6 @@ final class AddPropertyTypeDeclaration { - /** - * @param class-string $class - */ public function __construct( private readonly string $class, private readonly string $propertyName, diff --git a/rules/TypeDeclaration/ValueObject/AddReturnTypeDeclaration.php b/rules/TypeDeclaration/ValueObject/AddReturnTypeDeclaration.php index 039d0dd54bd..47125ec82af 100644 --- a/rules/TypeDeclaration/ValueObject/AddReturnTypeDeclaration.php +++ b/rules/TypeDeclaration/ValueObject/AddReturnTypeDeclaration.php @@ -10,9 +10,6 @@ final class AddReturnTypeDeclaration { - /** - * @param class-string $class - */ public function __construct( private readonly string $class, private readonly string $method, diff --git a/rules/Visibility/ValueObject/ChangeConstantVisibility.php b/rules/Visibility/ValueObject/ChangeConstantVisibility.php index 3a00c7a45ab..cc59cb98fa4 100644 --- a/rules/Visibility/ValueObject/ChangeConstantVisibility.php +++ b/rules/Visibility/ValueObject/ChangeConstantVisibility.php @@ -9,9 +9,6 @@ final class ChangeConstantVisibility { - /** - * @param class-string $class - */ public function __construct( private readonly string $class, private readonly string $constant, diff --git a/rules/Visibility/ValueObject/ChangeMethodVisibility.php b/rules/Visibility/ValueObject/ChangeMethodVisibility.php index eafe425cee0..d7984edbb84 100644 --- a/rules/Visibility/ValueObject/ChangeMethodVisibility.php +++ b/rules/Visibility/ValueObject/ChangeMethodVisibility.php @@ -8,9 +8,6 @@ final class ChangeMethodVisibility { - /** - * @param class-string $class - */ public function __construct( private readonly string $class, private readonly string $method,