-
-
Notifications
You must be signed in to change notification settings - Fork 333
/
RemoveAlwaysTrueIfConditionRector.php
135 lines (113 loc) · 3.26 KB
/
RemoveAlwaysTrueIfConditionRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
<?php
declare(strict_types=1);
namespace Rector\DeadCode\Rector\If_;
use PhpParser\Node;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\PropertyFetch;
use PhpParser\Node\Expr\StaticPropertyFetch;
use PhpParser\Node\Stmt;
use PhpParser\Node\Stmt\If_;
use PHPStan\Reflection\ClassReflection;
use PHPStan\Type\Constant\ConstantBooleanType;
use Rector\Core\Rector\AbstractRector;
use Rector\Core\Reflection\ReflectionResolver;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\DeadCode\Rector\If_\RemoveAlwaysTrueIfConditionRector\RemoveAlwaysTrueIfConditionRectorTest
*/
final class RemoveAlwaysTrueIfConditionRector extends AbstractRector
{
public function __construct(private readonly ReflectionResolver $reflectionResolver)
{
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition('Remove if condition that is always true', [
new CodeSample(
<<<'CODE_SAMPLE'
final class SomeClass
{
public function go()
{
if (1 === 1) {
return 'yes';
}
return 'no';
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
final class SomeClass
{
public function go()
{
return 'yes';
return 'no';
}
}
CODE_SAMPLE
),
]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [If_::class];
}
/**
* @param If_ $node
* @return If_|null|Stmt[]
*/
public function refactor(Node $node): If_|null|array
{
if ($node->else !== null) {
return null;
}
// just one if
if ($node->elseifs !== []) {
return null;
}
$conditionStaticType = $this->getType($node->cond);
if (! $conditionStaticType instanceof ConstantBooleanType) {
return null;
}
if (! $conditionStaticType->getValue()) {
return null;
}
if ($this->shouldSkipPropertyFetch($node->cond)) {
return null;
}
if ($node->stmts === []) {
$this->removeNode($node);
return null;
}
return $node->stmts;
}
private function shouldSkipPropertyFetch(Expr $expr): bool
{
/** @var PropertyFetch[]|StaticPropertyFetch[] $propertyFetches */
$propertyFetches = $this->betterNodeFinder->findInstancesOf(
$expr,
[PropertyFetch::class, StaticPropertyFetch::class]
);
foreach ($propertyFetches as $propertyFetch) {
$classReflection = $this->reflectionResolver->resolveClassReflectionSourceObject($propertyFetch);
if (! $classReflection instanceof ClassReflection) {
continue;
}
$propertyName = (string) $this->nodeNameResolver->getName($propertyFetch);
if (! $classReflection->hasNativeProperty($propertyName)) {
continue;
}
$nativeProperty = $classReflection->getNativeProperty($propertyName);
if (! $nativeProperty->hasNativeType()) {
return true;
}
}
return false;
}
}