-
-
Notifications
You must be signed in to change notification settings - Fork 333
/
CountArrayToEmptyArrayComparisonRector.php
193 lines (157 loc) · 5.3 KB
/
CountArrayToEmptyArrayComparisonRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
<?php
declare(strict_types=1);
namespace Rector\CodingStyle\Rector\FuncCall;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\Array_;
use PhpParser\Node\Expr\BinaryOp\Greater;
use PhpParser\Node\Expr\BinaryOp\Identical;
use PhpParser\Node\Expr\BinaryOp\NotIdentical;
use PhpParser\Node\Expr\BinaryOp\Smaller;
use PhpParser\Node\Expr\BooleanNot;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Scalar\LNumber;
use PhpParser\Node\Stmt\ElseIf_;
use PhpParser\Node\Stmt\If_;
use PHPStan\Type\ArrayType;
use Rector\Core\Rector\AbstractRector;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\CodingStyle\Rector\FuncCall\CountArrayToEmptyArrayComparisonRector\CountArrayToEmptyArrayComparisonRectorTest
*/
final class CountArrayToEmptyArrayComparisonRector extends AbstractRector
{
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Change count array comparison to empty array comparison to improve performance',
[
new CodeSample(
<<<'CODE_SAMPLE'
count($array) === 0;
count($array) > 0;
! count($array);
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
$array === [];
$array !== [];
$array === [];
CODE_SAMPLE
),
]
);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [FuncCall::class, BooleanNot::class];
}
/**
* @param FuncCall|BooleanNot $node
*/
public function refactor(Node $node): ?Node
{
if ($node instanceof BooleanNot) {
return $this->processMarkTruthyNegation($node);
}
if (! $this->isName($node, 'count')) {
return null;
}
if (! isset($node->args[0])) {
return null;
}
if (! $node->args[0] instanceof Arg) {
return null;
}
/** @var Expr $expr */
$expr = $node->args[0]->value;
// not pass array type, skip
if (! $this->isArray($expr)) {
return null;
}
$parent = $node->getAttribute(AttributeKey::PARENT_NODE);
if (! $parent instanceof Node) {
return null;
}
$processIdentical = $this->processIdenticalOrNotIdentical($parent, $node, $expr);
if ($processIdentical !== null) {
return $processIdentical;
}
$processGreaterOrSmaller = $this->processGreaterOrSmaller($parent, $node, $expr);
if ($processGreaterOrSmaller !== null) {
return $processGreaterOrSmaller;
}
return $this->processMarkTruthy($parent, $node, $expr);
}
private function processMarkTruthyNegation(BooleanNot $booleanNot): ?Identical
{
if (! $booleanNot->expr instanceof FuncCall) {
return null;
}
if (! $this->isName($booleanNot->expr, 'count')) {
return null;
}
if (! isset($booleanNot->expr->args[0])) {
return null;
}
if (! $booleanNot->expr->args[0] instanceof Arg) {
return null;
}
/** @var Expr $expr */
$expr = $booleanNot->expr->args[0]->value;
// not pass array type, skip
if (! $this->isArray($expr)) {
return null;
}
return new Identical($expr, new Array_([]));
}
private function isArray(Expr $expr): bool
{
return $this->getType($expr) instanceof ArrayType;
}
private function processIdenticalOrNotIdentical(Node $node, FuncCall $funcCall, Expr $expr): ?Expr
{
if (($node instanceof Identical || $node instanceof NotIdentical) && $node->right instanceof LNumber && $node->right->value === 0) {
$this->removeNode($funcCall);
$node->right = new Array_([]);
return $expr;
}
if (($node instanceof Identical || $node instanceof NotIdentical) && $node->left instanceof LNumber && $node->left->value === 0) {
$this->removeNode($funcCall);
$node->left = new Array_([]);
return $expr;
}
return null;
}
private function processGreaterOrSmaller(Node $node, FuncCall $funcCall, Expr $expr): ?NotIdentical
{
if ($node instanceof Greater && $node->right instanceof LNumber && $node->right->value === 0) {
$this->removeNode($funcCall);
$this->removeNode($node->right);
return new NotIdentical($expr, new Array_([]));
}
if ($node instanceof Smaller && $node->left instanceof LNumber && $node->left->value === 0) {
$this->removeNode($funcCall);
$this->removeNode($node->left);
return new NotIdentical(new Array_([]), $expr);
}
return null;
}
private function processMarkTruthy(Node $node, FuncCall $funcCall, Expr $expr): ?Expr
{
if (! $node instanceof If_ && ! $node instanceof ElseIf_) {
return null;
}
if ($node->cond === $funcCall) {
$node->cond = new NotIdentical($expr, new Array_([]));
return $node->cond;
}
return null;
}
}