-
-
Notifications
You must be signed in to change notification settings - Fork 336
/
ForRepeatedCountToOwnVariableRector.php
119 lines (103 loc) · 2.8 KB
/
ForRepeatedCountToOwnVariableRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
<?php
declare(strict_types=1);
namespace Rector\CodeQuality\Rector\For_;
use PhpParser\Node;
use PhpParser\Node\Expr\Assign;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Stmt;
use PhpParser\Node\Stmt\Expression;
use PhpParser\Node\Stmt\For_;
use PHPStan\Analyser\Scope;
use Rector\Core\Rector\AbstractScopeAwareRector;
use Rector\Naming\Naming\VariableNaming;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\CodeQuality\Rector\For_\ForRepeatedCountToOwnVariableRector\ForRepeatedCountToOwnVariableRectorTest
*/
final class ForRepeatedCountToOwnVariableRector extends AbstractScopeAwareRector
{
public function __construct(
private readonly VariableNaming $variableNaming
) {
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Change count() in for function to own variable',
[
new CodeSample(
<<<'CODE_SAMPLE'
class SomeClass
{
public function run($items)
{
for ($i = 5; $i <= count($items); $i++) {
echo $items[$i];
}
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
class SomeClass
{
public function run($items)
{
$itemsCount = count($items);
for ($i = 5; $i <= $itemsCount; $i++) {
echo $items[$i];
}
}
}
CODE_SAMPLE
),
]
);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [For_::class];
}
/**
* @param For_ $node
* @return Stmt[]|null
*/
public function refactorWithScope(Node $node, Scope $scope): ?array
{
$countInCond = null;
$variableName = null;
$this->traverseNodesWithCallable($node->cond, function (Node $node) use (
&$countInCond,
&$variableName,
$scope
): ?Variable {
if (! $node instanceof FuncCall) {
return null;
}
if (! $this->isName($node, 'count')) {
return null;
}
$countInCond = $node;
$variableName = $this->variableNaming->resolveFromFuncCallFirstArgumentWithSuffix(
$node,
'Count',
'itemsCount',
$scope
);
return new Variable($variableName);
});
if ($countInCond === null) {
return null;
}
if ($variableName === null) {
return null;
}
$countAssign = new Assign(new Variable($variableName), $countInCond);
return [new Expression($countAssign), $node];
}
}