Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aspect Oriented Hooks #500

Open
squeedee opened this issue Mar 27, 2024 · 3 comments
Open

Aspect Oriented Hooks #500

squeedee opened this issue Mar 27, 2024 · 3 comments

Comments

@squeedee
Copy link
Collaborator

I would like a way to add start/end/around hooks to any reconciler or sub-reconciler object.
My main use case for this is to add additional logging and add span data to the context for tracing.
The injected methods would need access to the context (with the ability to provide a replacement in arounds )

@squeedee
Copy link
Collaborator Author

In my mind, the simplest mechanism is to add a [before|after|around]reconcile method to all the reconcilers and subreconciler's interfaces. I'm sure a general pointcut solution for callbacks such as ReflectChildStatus has possible benefits, but I don't know if there's any point in complicating the whole engine with "true" AOP?

@squeedee
Copy link
Collaborator Author

We love what you implemented in #502 but there's been no movement for 3 weeks. What can we do to get this over the line? CC @scothis

@scothis
Copy link
Contributor

scothis commented May 15, 2024

What's missing from that PR right now is tests and doc. I have a family obligation coming up, so it will be at least another week before I can fully finish it off. I don't expect the API shape to change much, so you can start building on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants