Fix serialization in filesystem backend with binary content that is also valid UTF-8 #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JWCook
added
bug
serialization
rasmuse
reviewed
Feb 15, 2022
| @@ -70,8 +74,8 @@ def safe_pickle_serializer( | |||
| import bson | |||
|
|
|||
| bson_serializer = SerializerPipeline( | |||
| [bson_preconf_stage, bson] | |||
| ) #: Complete BSON serializer; using pymongo's ``bson.json_util`` if installed, otherwise standalone ``bson`` codec | |||
| [bson_preconf_stage, bson], is_binary=False | |||
There was a problem hiding this comment.
Unless I'm making a mistake, bson should have is_binary=True, right? It's one of the two binary formats pointed out in the original bug report: #507
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #507