Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabling expiration for a single request #527

Merged
merged 3 commits into from Feb 15, 2022
Merged

Fix disabling expiration for a single request #527

merged 3 commits into from Feb 15, 2022

Conversation

JWCook
Copy link
Member

@JWCook JWCook commented Feb 15, 2022

Closes #526

Looks like this was previously working in 0.8.x, but broke with #406. A test has been added to cover this.

@JWCook JWCook added the bug label Feb 15, 2022
@JWCook JWCook added this to the v0.9 milestone Feb 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2022

Codecov Report

Merging #527 (b2ad34e) into master (04ff30b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #527   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          18       18           
  Lines        1295     1299    +4     
  Branches      205      205           
=======================================
+ Hits         1277     1281    +4     
  Misses          9        9           
  Partials        9        9           
Impacted Files Coverage Δ
requests_cache/cache_control.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04ff30b...b2ad34e. Read the comment docs.

@JWCook JWCook marked this pull request as ready for review February 15, 2022 19:01
@JWCook JWCook merged commit c2baccd into requests-cache:master Feb 15, 2022
@JWCook JWCook deleted the fix-expire-override branch February 15, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expire_after with value -1 in session.request doesn't override CachedSession.expire_after
2 participants