From d0ca723768861799e3b966278156f8f970a70d1c Mon Sep 17 00:00:00 2001 From: Dalton Craven Date: Tue, 2 Aug 2022 00:09:29 +0200 Subject: [PATCH 1/2] Fix typing of default tooltip formatter --- src/component/DefaultTooltipContent.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/component/DefaultTooltipContent.tsx b/src/component/DefaultTooltipContent.tsx index 2870d83b8c..0b6724f561 100644 --- a/src/component/DefaultTooltipContent.tsx +++ b/src/component/DefaultTooltipContent.tsx @@ -6,8 +6,8 @@ import React, { PureComponent, CSSProperties, ReactNode } from 'react'; import classNames from 'classnames'; import { isNumOrStr } from '../util/DataUtils'; -function defaultFormatter(value: T) { - return _.isArray(value) && isNumOrStr(value[0]) && isNumOrStr(value[1]) ? value.join(' ~ ') : value; +function defaultFormatter(value: TValue) { + return _.isArray(value) && isNumOrStr(value[0]) && isNumOrStr(value[1]) ? (value.join(' ~ ') as TValue) : value; } export type TooltipType = 'none'; @@ -19,7 +19,7 @@ export type Formatter = ( item: Payload, index: number, payload: Array>, -) => [ReactNode, ReactNode] | ReactNode; +) => [TValue, TName] | TValue; export interface Payload { type?: TooltipType; @@ -82,7 +82,7 @@ export class DefaultTooltipContent Date: Tue, 2 Aug 2022 17:08:14 +0200 Subject: [PATCH 2/2] Add eslint disable to Tooltip Co-authored-by: saghan --- src/component/Tooltip.tsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/component/Tooltip.tsx b/src/component/Tooltip.tsx index ef0b93f22e..bef89e06c5 100644 --- a/src/component/Tooltip.tsx +++ b/src/component/Tooltip.tsx @@ -258,8 +258,12 @@ export class Tooltip extends P }); return ( + // ESLint is disabled to allow listening to the `Escape` key. Refer to + // https://github.com/recharts/recharts/pull/2925 + // eslint-disable-next-line jsx-a11y/no-noninteractive-element-interactions
{ if (event.key === 'Escape') { this.setState({