ErrorBar does not animate #4055
Labels
enhancement
Enhancement to a current API
Comments
|
I think this has always been the case. Labeled for now |
ckifer
pushed a commit
that referenced
this issue
Mar 21, 2024
## Description Added animation for ErrorBar component ## Related Issue [ErrorBar does not animate](#4055) ## Motivation and Context Previously the ErrorBar didn't have animation, now animation has been introduced to make it have a smoother visual effect ## How Has This Been Tested? It was tested locally with Storybook and validated through unit tests ## Screenshots (if appropriate): https://github.com/recharts/recharts/assets/41566276/32d7f85b-3e10-47de-87a8-ac5edd018072 ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [x] I have added tests to cover my changes. - [ ] I have added a storybook story or extended an existing story to show my changes
7 tasks
ckifer
pushed a commit
that referenced
this issue
Apr 15, 2024
## Description The current `ErrorBar` animation transitions from left to right. According to the discussions in the previous [PR](#4311), it has now been changed to expand centrally towards both the top and bottom ## Related Issue [ErrorBar does not animate](#4055) ## Motivation and Context ## How Has This Been Tested? It was tested locally with Storybook and validated through unit tests ## Screenshots (if appropriate): https://github.com/recharts/recharts/assets/41566276/2fe5908b-4d83-4664-821d-761cd20e847e ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [x] I have added tests to cover my changes. - [ ] I have added a storybook story or extended an existing story to show my changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reproduction link
https://master--63da8268a0da9970db6992aa.chromatic.com/?path=/docs/api-cartesian-errorbar--docs
Steps to reproduce
Simply check out the example in the Storybook.
What is expected?
For the error bars to animate when they appear.
What is actually happening?
The error bars simply pop in.
The text was updated successfully, but these errors were encountered: