Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Still) Looking for contributors - a Recharts Status Update #3407

Open
ckifer opened this issue Feb 27, 2023 · 15 comments
Open

(Still) Looking for contributors - a Recharts Status Update #3407

ckifer opened this issue Feb 27, 2023 · 15 comments
Labels
P0 Critical priority issues

Comments

@ckifer
Copy link
Member

ckifer commented Feb 27, 2023 •
edited

Hi all,

Going to pin this as a new issue out of the old one: #1833

We've figured some things out since then! First of all, thanks to the creator of recharts @arcthur for helping us get the project into the hands of more contributors and maintainers. We want to help recharts to be better, fix bugs, implement features, increase documentation, etc. We couldn't do that with very much velocity without communication, without direction, or without access.

We now have a recharts Slack channel for communication between those who are collaborating or wish to help collaborate on the project: Join here - this is a contributors slack channel, please don't use the slack channel for issues

Secondly, thanks to those who have joined as interested or invested members of the community - nothing can happen without individuals willing to put in time and effort to manage the community, manage issues, dive into bugs, update documentation, etc. Huge shoutouts to the following:

...And many more

We've accomplished a few minor released and bug fixes. Notably:

  • Security vulnerability fix using victory-vendor
  • Migration to Jest and RTL
  • Addition of Storybook and trying to better documentation
  • More...

All that said we still need help! All/most of us are contributing to this library because we either like it and have used it in the past, or are currently using it for day jobs. Any contributions, suggestions, bug deep dives, performance profiles, documentation fixes/improvements, etc. are greatly appreciated by the community.

If you want to help us please join the slack.

Cheers!

Edit 8/9/2023 - status remains the same, please please consider contributing if you are a heavy user of the project
Edit 3/19/2024 - status remains the same, need more long-term contributors. Work has begun on 3.x
@ckifer ckifer added the P0 Critical priority issues label Feb 27, 2023
@ckifer ckifer pinned this issue Feb 27, 2023
@ckifer
Copy link
Member Author

ckifer commented Aug 30, 2023

https://www.reddit.com/r/reactjs/comments/1656wi9/recharts_call_for_contributors/?utm_source=share&utm_medium=web2x&context=3

@TheHumanistX
Copy link

I am a pretty new developer, but my focus has mostly been CSS/React up to this point with some Java and Python sprinkled in. What could someone like me do to contribute? I find this library interesting because I have degrees in math/stats. Fair warning, I haven't practiced much of either in about 10 years... so, I could probably help with that end of things but I'd need very specific direction and then a little time to grease the wheels. Otherwise, what else is there for someone with not a ton of experience?

@ckifer
Copy link
Member Author

ckifer commented Aug 30, 2023

@TheHumanistX sweet! I think someone with some math background is a huge help, I hate math 😂.

I need to tag more issues with "good first issue", but helping with the docs is always good (and will help get you familiar with the library). We're still in progress of moving the website over to storybook. I'll tag and create a few issues today.

@GasimGasimzada
Copy link

GasimGasimzada commented Aug 30, 2023 •
edited

Hi @ckifer, is there a roadmap or some kind of plan on what the maintainers are going to work on? I would like to be involved in becoming a contributor but I need to know what is expected from contributors.

@TheHumanistX
Copy link

@ckifer Just tag me when you have some things ready you think maybe I could help with. I have never contributed to a project before so this may take a second for me to understand and get used to.

@ckifer
Copy link
Member Author

ckifer commented Aug 30, 2023 •
edited

@GasimGasimzada no there isn't currently a coherent roadmap at the moment. Myself and @nikolasrieble can work on putting that together - we know direction, but exacts are squishy.

We would like to move towards a 3.x release which contains many of the breaking changes we currently have pending. That release would ideally include a subset of these things (on mobile, will link issues later):

  1. Right now we use victory-vendor as a mirror for d3 because d3 is ESM only. If we can move back to d3 without breaking cjs consumers that would be great.
  2. Refactor generateCategoticalChart - this has a lot of potential for breaking things but it needs done. We were thinking by chart category (Cartesian, polar, centric) first, and then go from there.
  3. Reduce bundle size - current bundle size is quite large, reducing it by any amount is a win
  4. Finish docs migration to storybook - a lot of this is done but there's a ton we can improve there
  5. Throw better errors and warnings in dev mode - we just started using the invariant pattern
  6. Speed/rendering improvements - not my highest priority but recharts has a ton of unneeded rerenders
  7. Refactor to function components - started but not done. Have to be careful here because recharts does some magic and random things break upon refactorings (insert tooltip issue here)
  8. Remove any and all "magic" if possible - I'll add more details on this
  9. Solving issues with highest reactions

Overwhelmingly my goal is: make this project more robust and easier to maintain. Right now it is fragile and difficult.

@GasimGasimzada
Copy link

Thank you for the brief information. Could you count me in to contribute?

@abdnafees
Copy link

Hey @ckifer, I hope you are doing well. Please count me in. I am a junior dev but would love to help in any way possible.

@ckifer
Copy link
Member Author

ckifer commented Sep 12, 2023

The more the merrier, welcome!

@nikolasrieble
Copy link
Contributor

nikolasrieble commented Sep 12, 2023 •
edited

For what it is worth, I tried to summarise our current initiatives with a bit more detail.
Happy to extend it depending our any feedback or questions you might have.

@abdnafees
Copy link

@nikolasrieble I can work on the docs. I have experience with that. Not so confident with open-source code at the moment.

@nikolasrieble
Copy link
Contributor

@abdnafees We would love feedback on our storybook. There are also quite a few open issues with storybook. You could help with reviewing the existing documentation, improving it, creating issues, or right away adding stories to finish the first milestone for a complete documentation in storybook.

@abdnafees
Copy link

@nikolasrieble Got it, I will get started right away.

@MateuszTrN MateuszTrN mentioned this issue Sep 15, 2023
Merged
8 tasks
MateuszTrN pushed a commit to MateuszTrN/recharts that referenced this issue Sep 15, 2023
Merge branch 'master' of github.com:recharts/recharts into chore/i(re…
b680492 
…charts#3407)-new-steps-in-contribution-md

# Conflicts:
#	CONTRIBUTING.md
@o0vO
Copy link

o0vO commented Jan 26, 2024

Hello @ckifer, can I join in right now. Can pick anything

@nikolasrieble
Copy link
Contributor

Hi @o0vO you can join any time! Please start by looking into open issues that are tagged good first issue

Other than that, we need help all across the board: Responding to issues, helping user reproduce, extending documentation and reviewing PRs.

@ckifer ckifer mentioned this issue Feb 5, 2024
Open
1 task
@ckifer ckifer mentioned this issue Feb 21, 2024
Closed
1 task
@ckifer ckifer mentioned this issue Mar 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P0 Critical priority issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@GasimGasimzada @abdnafees @ckifer @nikolasrieble @TheHumanistX @o0vO