New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When multiple charts with Brush are synced, Brush doesn't get updated #3027
Comments
I use one brush for various sync charts. In case that is not a requirement to have a brush for each chart, it works. Though, it's a workaround and does not close this issue. |
I think the intention is @natBizitza 's suggestion which is to have one brush to control all synced charts. I will label this as a feature request for prioritization |
@ckifer Brushes from synced charts do not get automatically updated when you drag one of them. To make matters worse, the I feel like it's more of a bug than a feature request, to be honest. |
Not respecting start and end index is a bug (though one I thought was fixed), but supporting a synced brush is a feature request. Feel free to create a new issue for the index problem |
This PR should have fixed the index issue.. #4034. Released in 2.10.4 |
@ckifer |
I am facing a similar issue. I tried to create an empty Composed Graph with just a brush child component. While this somewhat solves the problem. I started getting a lot of cant read properties of null. From what I could understand this was because tooltip was being synced across the charts and the chart with only brush has no tooltip/graphical components to fetch tooltip information from. I was also not able to hide the tooltip to make the null issue go away. This is quite frustrating because currently there is no way to sync multiple graphs cleanly that use brushes. My layout doesn't allow me to just put brush on a random chart. |
Please see my responses here #4163 (comment) You get errors with an empty chart because Brush relies on state from other components (XAxis) in order to work correctly. We can make error messaging better there. Hopefully, this becomes an easier issue to resolve in 3.x with the refactoring we're doing, but right now it doesn't seem possible without making the UX worse than it currently is (see video in the other thread) |
@ckifer A hacky fix but I fixed it by adding a hidden
|
Decent workaround for now for sure! I know exactly what the work is to allow this the correct way and luckily it will get done indirectly as a result of other ongoing refactoring |
Are there any updates for this? Being unable to setState inside the onchange controller on a brush is blocking some features we would like to ship. |
@yogasanas see #4163 (comment) and the video below that. Refactoring is ongoing but we haven't gotten here yet |
Reproduction link
Steps to reproduce
Interact with any Brush. All the charts will react to the change of Brush, but other Brush components don't update.
What is expected?
Brush components get synced (update their handle positions accordingly).
What is actually happening?
Brush components not responding.
I found a similar issue from 2 years ago: #1796
This issue is supposed to be fixed, and I still see the problem. I wonder if I am missing anything?
(It seems recent releases are missing from the dropdown, but I did try with the latest release.)
The text was updated successfully, but these errors were encountered: