Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing of default tooltip formatter #2924

Merged
merged 2 commits into from Aug 22, 2022
Merged

Fix typing of default tooltip formatter #2924

merged 2 commits into from Aug 22, 2022

Conversation

cravend
Copy link
Contributor

@cravend cravend commented Aug 1, 2022

Tied to #2916, this PR updates the typing to the default formatter to prevent it from failing the TSC build.

Closes #2925

@cravend
Copy link
Contributor Author

cravend commented Aug 1, 2022

@saghan now I'm getting another error regarding the accessibility of the tooltip, looks like it's tied to #2914. Not sure why it's just now popping up, but do you have any thoughts on the best way to fix it?

image

@saghan
Copy link
Contributor

saghan commented Aug 1, 2022

@cravend I am looking into it.

@saghan
Copy link
Contributor

saghan commented Aug 1, 2022

@cravend Could you try disabling the linter with these comments?
// eslint-disable-next-line jsx-a11y/no-noninteractive-element-interactions
<div
tabIndex={-1}
role="dialog"
onKeyDown={event => {
if (event.key === 'Escape') {


We need to disable the linter here because the div needs to listen to keypress

@saghan
Copy link
Contributor

saghan commented Aug 1, 2022

I have also created a draft here:
#2925
I think it might be better to have your PR contain the changes. This way all errors will be resolved in a single PR and we don't have to force merge any PR with build errors.

Co-authored-by: saghan <saghan99@gmail.com>
@arcthur arcthur merged commit da6b9e2 into recharts:master Aug 22, 2022
arcthur added a commit that referenced this pull request Sep 6, 2022
* 'master' of https://github.com/recharts/recharts:
  Add inactiveShape prop to Pie component (#2900)
  Revert "chore: move type deps into devDependencies (#2843)" (#2942)
  Fix typing of default tooltip formatter (#2924)
  done (#2936)
  Take letter-spacing and font-size into consideration while rendering ticks (#2898)
  Add formatter function type to tooltip props (#2916)
  doc: Update CHANGELOG.md about d3 7.x (#2919)
furrycatherder added a commit to furrycatherder/recharts that referenced this pull request Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants