Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatter function type to tooltip props #2916

Merged
merged 1 commit into from Jul 28, 2022
Merged

Add formatter function type to tooltip props #2916

merged 1 commit into from Jul 28, 2022

Conversation

cravend
Copy link
Contributor

@cravend cravend commented Jul 27, 2022

This updates the prop validation of a tooltip formatter prop to not allow any arbitrary function.

@arcthur arcthur merged commit 6b3cce4 into recharts:master Jul 28, 2022
@saghan
Copy link
Contributor

saghan commented Aug 1, 2022

@cravend @arcthur This change causes build error shown in screenshot below:
Screen Shot 2022-08-01 at 1 15 52 PM

arcthur added a commit that referenced this pull request Sep 6, 2022
* 'master' of https://github.com/recharts/recharts:
  Add inactiveShape prop to Pie component (#2900)
  Revert "chore: move type deps into devDependencies (#2843)" (#2942)
  Fix typing of default tooltip formatter (#2924)
  done (#2936)
  Take letter-spacing and font-size into consideration while rendering ticks (#2898)
  Add formatter function type to tooltip props (#2916)
  doc: Update CHANGELOG.md about d3 7.x (#2919)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants