Add inactiveShape prop to Pie component #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscrosati
approved these changes
Jul 13, 2022
| @@ -87,6 +87,7 @@ interface PieProps extends PieDef { | |||
| data?: any[]; | |||
| sectors?: PieSectorDataItem[]; | |||
| activeShape?: PieActiveShape; | |||
| inactiveShape?: PieActiveShape; | |||
There was a problem hiding this comment.
nitty: Should we consider renaming the interface PieActiveShape to PieShape? Disregard if this would cause a breaking change though.
|
@arcthur and @xile611 , this PR proposal is a contribution that isn't accessibility driven directly, but allows to developer to interact and redraw the non active shapes of a pie, such that their accessibility characteristics are improved in relation to the active one. Let us know if you have concerns with the naming of the API, or any other topics. |
|
Note: this PR provides is supporting #2801 |
arcthur
added a commit
that referenced
this pull request
Sep 6, 2022
* 'master' of https://github.com/recharts/recharts: Add inactiveShape prop to Pie component (#2900) Revert "chore: move type deps into devDependencies (#2843)" (#2942) Fix typing of default tooltip formatter (#2924) done (#2936) Take letter-spacing and font-size into consideration while rendering ticks (#2898) Add formatter function type to tooltip props (#2916) doc: Update CHANGELOG.md about d3 7.x (#2919)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Our team has the need to change the appearance of a piechart when one of the sectors is hovered/selected. For the hovered sectors we could achieve that with the existing api
activeShape. However (correct me if I'm wrong) the existing api doesn't provide the ability to customize the look of other sectors. Thus I'm proposing to add an API for that.I'm calling the new API
inactiveShape, similar toactiveShape. The API, if provided, allows the users to customize how inactive sectors look like, when a validactiveIndexprop is provided.Please let me know how you think of this. Also raised a PR to update the docs.
recharts/recharts.org#196
I'll also update the demo and add a codesandbox link once ethis PR is merged.
Thanks