Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade d3 to 7.X #2893

Merged
merged 1 commit into from Jul 20, 2022

Conversation

jmfrancois
Copy link
Contributor

@jmfrancois jmfrancois commented Jun 30, 2022

current recharts release are based on d3 6.x
We have the following subset of d3-* deps which are not aligned with d3 7.x

├─ d3-array@2.12.1
├─ d3-color@2.0.0
├─ d3-format@2.0.0
├─ d3-interpolate@2.0.1
├─ d3-path@2.0.0
├─ d3-scale@3.3.0
├─ d3-shape@2.1.0
├─ d3-time-format@3.0.0
└─ d3-time@2.1.1

I propose the following change to be aligned with d3 7.x

├─ d3-array@3.1.6
├─ d3-color@3.1.0
├─ d3-format@3.1.0
├─ d3-interpolate@3.0.1
├─ d3-path@3.0.1
├─ d3-scale@4.0.2
├─ d3-shape@3.1.0
├─ d3-time-format@4.1.0
└─ d3-time@3.0.0

I have runned test, all tests are green.
I have executed build which is ok
I have used the demo and play with each samples.

it seems this upgrade came for free 👍

@jmfrancois
Copy link
Contributor Author

Hey @arcthur would you mind to review this PR ?
Do you think this should be a major release ? (I don't think so) d3 is already quite used in 7.x looking at npm stats: https://www.npmjs.com/package/d3?activeTab=versions and it do not change the recharts API.

@arcthur arcthur merged commit 324a4ee into recharts:master Jul 20, 2022
@jmfrancois jmfrancois deleted the jmfrancois/feat/upgrade-to-d3 branch July 20, 2022 09:27
@WolfyUK
Copy link

WolfyUK commented Jul 26, 2022

Do you think this should be a major release

This major version dependency update should also bump at least the minor version for recharts. This broke our CI when 2.1.13 was released a few hours ago as d3-shape couldn't be compiled as expected using our existing jest configuration.

@WolfyUK WolfyUK mentioned this pull request Jul 27, 2022
@ryanolson-aumni
Copy link

ryanolson-aumni commented Oct 11, 2022

This broke things for our project.

it seems this upgrade came for free

Things aren't free in this world.

Do you think this should be a major release?

This should have been a major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants