Error bar domain fix #2863
Merged
Error bar domain fix #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2811
The basic idea of the fix is to use the layout of the parent component of the ErrorBar component in order to determine which axis domain the error bar should impact.
Before, this was determined by this code:
_.isNil(direction) || _.isNil(axisType) ? true : axisType.indexOf(direction) >= 0For direction 'x' however, both 'yAxis' and 'xAxis' contain 'x' and therefore both domains were impacted by the error bar.
Also, if the direction was not set, the error bar always had an impact on both axis domains.
In this fix, the logic if an error bar impacts the domain of an axis was extracted to a separate function for better readability and to give it an explicite name.