Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move type deps into devDependencies #2843

Merged
merged 1 commit into from May 2, 2022

Conversation

jmfrancois
Copy link
Contributor

Types dependencies are usefull only to build the package and check types.

Move @types/d3* into devDependencies

@jmfrancois
Copy link
Contributor Author

cc @xile611 please review !

@arcthur arcthur merged commit cbff5da into recharts:master May 2, 2022
@jmfrancois jmfrancois deleted the jmfrancois/fix/dependencies branch May 2, 2022 07:40
arcthur added a commit that referenced this pull request Sep 6, 2022
* 'master' of https://github.com/recharts/recharts:
  Add inactiveShape prop to Pie component (#2900)
  Revert "chore: move type deps into devDependencies (#2843)" (#2942)
  Fix typing of default tooltip formatter (#2924)
  done (#2936)
  Take letter-spacing and font-size into consideration while rendering ticks (#2898)
  Add formatter function type to tooltip props (#2916)
  doc: Update CHANGELOG.md about d3 7.x (#2919)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants