Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Re. Billing Feb & March Sherry FitzGerald #11031

Open
awogan06 opened this issue Apr 16, 2024 · 9 comments
Open

Query Re. Billing Feb & March Sherry FitzGerald #11031

awogan06 opened this issue Apr 16, 2024 · 9 comments
Assignees
Labels
back-end Relates to back end issues question Further information is requested

Comments

@awogan06
Copy link

Our API figures for “Appointments” seem to have taken a huge jump in Feb & March this year.

Our developer thinks this is related to an issue in Reapit where an appointment was stuck in a loop trying to update but Reapit continually returned a blank property code and so was never updated or removed from queue and there was nothing to alert us to this.

We don’t know if this was a bug or why the property would have been disassociated from the viewing. Our developer has put in some code to alert us if this happens again on our side. Can you get someone to shed some light on this with the viewing code below to see if this is why our costs increased considerable.

Viewing Issue.docx

@awogan06 awogan06 added needs-triage question Further information is requested labels Apr 16, 2024
@AshDeeming
Copy link

Hi @awogan06
Please could you advise your app name?

@awogan06
Copy link
Author

It's the SF Web Connector

@awogan06
Copy link
Author

awogan06 commented May 2, 2024

Good morning Ash I was just wondering if there was anything further on this?

@AshDeeming AshDeeming added the back-end Relates to back end issues label May 9, 2024
@AshDeeming AshDeeming added this to To review in Platform Backlog via automation May 9, 2024
@RWilcox-Reapit RWilcox-Reapit removed this from To review in Platform Backlog May 16, 2024
@RWilcox-Reapit RWilcox-Reapit added this to To do in Platform sprint 120 via automation May 16, 2024
@HollyJoyPhillips
Copy link
Contributor

Hi @awogan06 , we can’t see when the appointment was updated to remove the property ID but appointments can, although uncommon, be created without associated Property ID. The loop occurred as the appointment was updated (either via the SFG connector or in the CRM) and a webhook event fired. Based on that webhook the SFG connector created a PATCH (updated), this then triggered a webhook (correct behaviour).

However, each time it created a webhook event, the SFG connector ran another PATCH, which is where the loop continued until 2nd April.

As the system is designed to create events based on updates, it worked as it should. The response to each event may not have taken into account that the property ID wasn’t present.

Unfortunately, we only retain our logs for 1 month (due to the sheer size of each request) so it’s not possible to identify if it was the connector that updated the appointment and removed the property ID or if it was in AC but the loop wasn’t something that was executed via the Platform. Having read your comment though, it seems measures have been put in place from the connector side to cater for this going forward.

Hope that helps.

@HollyJoyPhillips HollyJoyPhillips moved this from To do to QA in Platform sprint 120 May 17, 2024
@awogan06
Copy link
Author

Thanks for coming back Holly. Yes our developer has put something in place to alert us if this happens again but it would have been good to identify if it was the connector that updated the appointment and removed the property ID or if it was in AC. I did raised this issue on 16th April so would you still not have had your logs for March at this time to review?

@HollyJoyPhillips
Copy link
Contributor

Hi @awogan06 unfortunately not with the amount of detail to determine when the property ID was dropped.

@awogan06
Copy link
Author

Thanks Holly

We had another example last week if that's any help

The property is TER210124,
Applicant ID is TER240361 and the appointment was for the 18th May

@HollyJoyPhillips
Copy link
Contributor

Hi @awogan06, that is helpful, thank you.

We were able to see the webhooks that were emitted on appointments modified on 13/05:

  • Appointment modified on 10:39 to change negotiator from TPT to DFL
  • Appointment modified at 15:33 which no longer included the property ID

The SFG Web Connector created a PATCH request on 15/05. This confirms it wasn't an integration or Platform that removed the property but was actioned within the CRM.

I would suggest reaching out to the CRM (Desktop Team) to obtain more detailed logs but as I understand it, their logs are only retained for 7 days. We're happy to help if you have a more recent example?

@awogan06
Copy link
Author

Thanks so much Holly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Relates to back end issues question Further information is requested
Projects
No open projects
Development

No branches or pull requests

4 participants