Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapit API's 500 error code #11010

Closed
KeithLowe opened this issue Apr 10, 2024 · 7 comments
Closed

Reapit API's 500 error code #11010

KeithLowe opened this issue Apr 10, 2024 · 7 comments
Assignees
Labels
back-end Relates to back end issues bug Something isn't working

Comments

@KeithLowe
Copy link

Issue with Reapit API, checked the logs and looks like we're getting 500s back from Reapit for QA + Live.
Test/uat appear to be OK.
Mostly looks like GetAppointment requests but there's a GetContacts one in there too - so could be all requests.

Status: 500
Response:
{"statusCode":500,"dateTime":"2024-04-10T14:49:30.1788935Z","description":"An unexpected error has been encountered when fulfilling this request. This incident has been logged and will be investigated. Please try again."})

To Reproduce
Some example calls from our tests earlier today:
___________________________________________________________________ (13:29:46.5677)
GET
https://platform.reapit.cloud/appointments/?pageNumber=1&pageSize=100&embed=property&negotiatorId=VVAI&negotiatorId=FRT8&negotiatorId=HWS9&negotiatorId=OP32&negotiatorId=FT72&negotiatorId=JCD4&negotiatorId=KRW4&negotiatorId=RTY7&negotiatorId=MNTD&negotiatorId=MWL&negotiatorId=LPP1&negotiatorId=ROU5&negotiatorId=K973&negotiatorId=SHP6&includeCancelled=false&includeUnconfirmed=true&fromArchive=false&officeId=MLB&start=2024-04-03T00%3A00%3A00.0000000Z&end=2024-05-22T00%3A00%3A00.0000000Z
Reapit Request Id: fd46bd66-e215-45db-a959-0374d95a42c7
Reapit Request Time: 00:00:25.2321882
Response: 500
____________________________________________________________________ (13:43:38.5594)
GET
https://platform.reapit.cloud/appointments/?pageNumber=1&pageSize=100&embed=property&negotiatorId=VVAI&negotiatorId=FRT8&negotiatorId=HWS9&negotiatorId=OP32&negotiatorId=FT72&negotiatorId=JCD4&negotiatorId=KRW4&negotiatorId=RTY7&negotiatorId=MNTD&negotiatorId=MWL&negotiatorId=LPP1&negotiatorId=ROU5&negotiatorId=K973&negotiatorId=SHP6&includeCancelled=false&includeUnconfirmed=true&fromArchive=false&officeId=MLB&start=2024-04-03T00%3A00%3A00.0000000Z&end=2024-05-22T00%3A00%3A00.0000000Z
Reapit Request Id: 294878bb-2297-4db8-a2a6-5f77595fc1aa
Reapit Request Time: 00:00:25.3080642
Response: 500

Using the live credentials - both had the same response as above in the debug logs

Expected behaviour
API transaction to be successfully processed!

Screenshots
n/a

@KeithLowe KeithLowe added bug Something isn't working needs-triage labels Apr 10, 2024
Copy link
Contributor

Thank you for taking the time to report a bug. We prioritise bugs depending on the severity and implications, so please ensure that you have provided as much information as possible. If you haven’t already, it really helps us to investigate the bug you have reported if you provide ‘Steps to Replicate’ and any associated screenshots.
Please ensure any personal information from the production database is obscured when submitting screenshots.
This issue will be reviewed in our weekly refinement sessions and assigned to a specific project board. We may also update the ticket to request additional information, if required.
For more information on our processes, please click here

@AshDeeming AshDeeming added back-end Relates to back end issues refinement To be included in a future refinement session and removed needs-triage labels Apr 11, 2024
@AshDeeming AshDeeming added this to To review in Platform Backlog via automation Apr 11, 2024
@RWilcox-Reapit RWilcox-Reapit moved this from To review to Near term in Platform Backlog Apr 11, 2024
Copy link
Contributor

This issue has been updated and moved to our ‘Near Term’ column (typically completed within 0 - 4 months). We have assessed the effort required and outlined a technical specification - please take the time to review this detail. When we're ready to schedule the issue, it will be assigned to the relevant board where you can continue to track its progress to completion.
For more information on our processes, please click here

@HollyJoyPhillips HollyJoyPhillips moved this from Near term to Bugs in Platform Backlog May 16, 2024
@HollyJoyPhillips HollyJoyPhillips added 3 3 story points and removed refinement To be included in a future refinement session labels May 17, 2024
@HollyJoyPhillips HollyJoyPhillips removed this from Bugs in Platform Backlog May 17, 2024
@HollyJoyPhillips HollyJoyPhillips added this to To do in Platform sprint 120 via automation May 17, 2024
@HollyJoyPhillips HollyJoyPhillips removed the 3 3 story points label May 17, 2024
@RWilcox-Reapit RWilcox-Reapit self-assigned this May 28, 2024
@RWilcox-Reapit RWilcox-Reapit moved this from To do to In progress in Platform sprint 120 May 28, 2024
@RWilcox-Reapit
Copy link
Contributor

Hi @KeithLowe
I have been looking into this issue today to understand what's causing this for a small number of clients.
In the instances and others pulled from logs I can see it's related to some negotiators being associated to large number of appointments.

One suggestion to prevent this for the immediate future would be to narrow down the start and end date params. The examples given above have a 7 week range which will result in a larger DB hit.

Can I ask the use case for pulling back 7 weeks worth of appointments in one hit, are you performing a data sync or is this for a screen?

I'm currently looking at ways to improve this query to prevent it timing out, this may end up being broken up into another ticket, I'll keep you updated on here.

Thanks

@KeithLowe
Copy link
Author

KeithLowe commented May 30, 2024 via email

@RWilcox-Reapit RWilcox-Reapit moved this from In progress to In review in Platform sprint 120 May 31, 2024
@RWilcox-Reapit
Copy link
Contributor

Hi @KeithLowe

I've recently put out some performance improvements to the appointments service. After some testing for your use cases above you should notice significant reductions in response time.

Thanks,
Ryan

@KeithLowe
Copy link
Author

KeithLowe commented Jun 4, 2024 via email

Copy link
Contributor

github-actions bot commented Jun 4, 2024

It looks like you have commented on a closed issue. If your comment relates to a bug or feature request, please open a new issue, and include this issue number/url for reference.
For more information on our processes, please click here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Relates to back end issues bug Something isn't working
Projects
Development

No branches or pull requests

4 participants