Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies between native build tasks and Java header generation #7729

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

rorbech
Copy link
Collaborator

@rorbech rorbech commented Sep 27, 2022

The native build task has a dependency for each abi, so we need to add a dependency to the Java header generating task for each of the native build tasks.

@rorbech
Copy link
Collaborator Author

rorbech commented Sep 27, 2022

Just to shed some light on what this changes means ... this is the dump of the pairs of externalNativeBuildDependency and compile${variant.name.capitalize()}JavaWithJavac for the various variants.

buildCMakeDebug[armeabi-v7a][realm-jni] compileBaseDebugJavaWithJavac
buildCMakeDebug[arm64-v8a][realm-jni] compileBaseDebugJavaWithJavac
buildCMakeDebug[x86_64][realm-jni] compileBaseDebugJavaWithJavac
buildCMakeDebug[x86][realm-jni] compileBaseDebugJavaWithJavac
buildCMakeDebug[armeabi-v7a][realm-jni]-2 compileObjectServerDebugJavaWithJavac
buildCMakeDebug[x86][realm-jni]-2 compileObjectServerDebugJavaWithJavac
buildCMakeDebug[arm64-v8a][realm-jni]-2 compileObjectServerDebugJavaWithJavac
buildCMakeDebug[x86_64][realm-jni]-2 compileObjectServerDebugJavaWithJavac
buildCMakeRelWithDebInfo[x86][realm-jni] compileBaseReleaseJavaWithJavac
buildCMakeRelWithDebInfo[x86_64][realm-jni] compileBaseReleaseJavaWithJavac
buildCMakeRelWithDebInfo[arm64-v8a][realm-jni] compileBaseReleaseJavaWithJavac
buildCMakeRelWithDebInfo[armeabi-v7a][realm-jni] compileBaseReleaseJavaWithJavac
buildCMakeRelWithDebInfo[x86][realm-jni]-2 compileObjectServerReleaseJavaWithJavac
buildCMakeRelWithDebInfo[x86_64][realm-jni]-2 compileObjectServerReleaseJavaWithJavac
buildCMakeRelWithDebInfo[arm64-v8a][realm-jni]-2 compileObjectServerReleaseJavaWithJavac
buildCMakeRelWithDebInfo[armeabi-v7a][realm-jni]-2 compileObjectServerReleaseJavaWithJavac

Copy link
Contributor

@cmelchior cmelchior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. If CI is happy 🚀

@rorbech rorbech merged commit 259dda3 into release/transformer-api Sep 28, 2022
@rorbech rorbech deleted the cr/transformer-api-release-fix branch September 28, 2022 08:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants