Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting FLX subscriptions when FLX sync is disabled should be an error #5079

Closed
sync-by-unito bot opened this issue Nov 30, 2021 · 2 comments · Fixed by #5637
Closed

Getting FLX subscriptions when FLX sync is disabled should be an error #5079

sync-by-unito bot opened this issue Nov 30, 2021 · 2 comments · Fixed by #5637
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Nov 30, 2021

At the object-store level, there should be a way to construct the SyncConfiguration in a way that indicates FLX sync is enabled and getting the subscriptions should fail if FLX sync is disabled.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 30, 2022

➤ Michael Wilkerson-Barker commented:

  • Updated Realm::get_latest_subscription_set() and Realm::get_active_subscription_set() to throw a runtime_error if called and flexible sync is not enabled.
  • Updated "flx: no subscription store created for PBS app" test case to verify the runtime_error is thrown.

Pull request: #5637

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 5, 2022

➤ Michael Wilkerson-Barker commented:

  • Updated Realm::get_latest_subscription_set() and Realm::get_active_subscription_set() to throw a runtime_error if called and flexible sync is not enabled.
  • Updated "flx: no subscription store created for PBS app" test case to verify the runtime_error is thrown.
  • Changes were reviewed and merged to 'master'

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants