Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 5.6 #1298

Merged
merged 7 commits into from Mar 17, 2022
Merged

Swift 5.6 #1298

merged 7 commits into from Mar 17, 2022

Conversation

johnfairh
Copy link
Collaborator

updated sourcekitten for sourcekit change

jazzy_swift - improved nonisolated decl printing

realm_objc - new @unchecked Sendable conformances for ObjC types

jazzy_objc - Sendable, plus an interesting consequence of the module-name changes that I’ll leave unchanged (module name in .jazzy.yaml doesn’t match SPM’s opinion) for coverage.

realm_swift - probably a Swift bug to do with override vs. @objc, opened SR-15815

@jpsim
Copy link
Collaborator

jpsim commented Feb 3, 2022

Might be worth updating the sourcekitten step in the Rakefile to build a universal binary:

swift build -c release --arch arm64 --arch x86_64

Thanks for doing this!

@johnfairh
Copy link
Collaborator Author

Oh will do -- despite cross-compiling all the time in other contexts my brain had decided that I couldn't do this without an M1 system...

Symbolgraph has annoyingly decided to start including some synthesized
declarations even when asked not to, with no indication that they are
not stuff users have written (PR 41141).  Only affects acl < public.
Xcode 13.3 needs macOS 12 which GitHub Actions does not support.
@johnfairh johnfairh marked this pull request as ready for review March 17, 2022 09:02
@johnfairh
Copy link
Collaborator Author

Because Xcode 13.3 needs macOS 12 and GitHub Actions doesn't support it, leave CI on Swift 5.5.

So this PR becomes just updating sourcekitten to a universal binary of its latest release.

@johnfairh johnfairh merged commit 2867df3 into master Mar 17, 2022
@johnfairh johnfairh deleted the jf-swift56 branch March 17, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants