Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML validation issues #1280

Closed
zorgiepoo opened this issue Sep 21, 2021 · 1 comment · Fixed by #1281
Closed

HTML validation issues #1280

zorgiepoo opened this issue Sep 21, 2021 · 1 comment · Fixed by #1281
Labels

Comments

@zorgiepoo
Copy link

zorgiepoo commented Sep 21, 2021

While integrating jazzy (v0.14.0) in our project's website using the jony theme, we ran into a couple issues with our CI validating the HTML. Some of these issues were invalid in our validator, but I think it caught a couple valid ones. They are also pointed out by a better online HTML validator for our website. Notably:

  • There is an extraneous closing </div> tag right before the ending </html> that doesn't have a matching opening <div>
  • img tags, eg <img id="carat" src="img/carat.png" /> don't have an alt attribute which is apparently required.
  • The online validator seems to be complaining about duplicate rel attributes, eg rel="noopener" rel="external", likely it wants rel="noopener external"

I'm not sure if there are other errors on other pages. Our website is here, although I think some of these issues surface in the example websites on this project and for other themes. Web browsers, or at least Safari, seem to present the webpages well so this is just overall a correctness issue (P.S, otherwise jazzy was great to integrate 👍)

@johnfairh johnfairh added the bug label Sep 21, 2021
@johnfairh
Copy link
Collaborator

Thanks for this, will look at fixing at least some of the errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants