Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially fix string_view encoder/decoder #640

Closed
wants to merge 1 commit into from

Conversation

kdkavanagh
Copy link

@kdkavanagh kdkavanagh commented Feb 4, 2019

Possibly fix #639. Please confirm this works properly with regard to null-terminated strings/inter-version compatibility

@mjpt777
Copy link
Contributor

mjpt777 commented Feb 4, 2019

I just beat you to this very fix. Thanks.

@mjpt777 mjpt777 closed this Feb 4, 2019
@mjpt777
Copy link
Contributor

mjpt777 commented Feb 4, 2019

The length is checked for the copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C++ generated string_view breaking for fixed length strings
2 participants