Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search page: don't show "edit on" links #935

Merged
merged 2 commits into from Jun 22, 2020
Merged

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jun 1, 2020

This page is autogenerated, so it doesn't have "a real page".

Fixes #934

This page is autogenerated, so it doesn't have "a real page".

Fixes #934
@stsewd stsewd requested a review from a team June 4, 2020 17:40
@agjohnson agjohnson requested review from a team and removed request for a team June 4, 2020 22:03
Copy link
Collaborator

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Test on the PR build seems to confirm it looks okay.

We'll hold off on merging until 0.5 is out though, I don't want more variability in that release.

@agjohnson agjohnson added the Status: blocked Issue is blocked on another issue label Jun 4, 2020
@stsewd
Copy link
Member Author

stsewd commented Jun 22, 2020

0.5 is out, merging this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search result page must not contain "Edit on GitHub" Link.
2 participants