Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analytics_anonymize_ip option to theme #889

Merged
merged 7 commits into from Oct 8, 2020

Conversation

septatrix
Copy link
Contributor

To easy usage according to the GDPR I added an option to enable anonymization of ip addresses when using Google Analytics

Copy link
Contributor

@jessetan jessetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a useful addition, but needs some small changes

sphinx_rtd_theme/layout.html Outdated Show resolved Hide resolved
docs/configuring.rst Outdated Show resolved Hide resolved
docs/configuring.rst Outdated Show resolved Hide resolved
sphinx_rtd_theme/theme.conf Outdated Show resolved Hide resolved
docs/configuring.rst Outdated Show resolved Hide resolved
septatrix and others added 2 commits March 27, 2020 20:46
Co-Authored-By: Jesse Tan <jessetan@users.noreply.github.com>
@septatrix septatrix requested a review from jessetan March 27, 2020 19:50
@agjohnson agjohnson modified the milestones: 0.5, 0.6 May 2, 2020
@septatrix
Copy link
Contributor Author

Any further feedback?

Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should add this to the changelog from master https://github.com/readthedocs/sphinx_rtd_theme/blob/master/docs/changelog.rst

@Blendify Blendify merged commit e2b60d7 into readthedocs:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants