Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcs_pageview_mode template parameter is not recognised #701

Closed
munhitsu opened this issue Dec 10, 2018 · 5 comments · Fixed by #1010
Closed

vcs_pageview_mode template parameter is not recognised #701

munhitsu opened this issue Dec 10, 2018 · 5 comments · Fixed by #1010
Labels
Bug A bug

Comments

@munhitsu
Copy link

Problem

Since #617, vcs_pageview_mode template parameter is not recognised anymore.
For html_theme_options attribute to be passed to theme it needs to be registered in theme.conf

Reproducible Project

N/A

Error Logs/Results

preparing documents... WARNING: unsupported theme option 'vcs_pageview_mode' given done

Expected Results

Please describe how this should work properly.

Environment Info

  • Python Version: 3.7.1
  • Sphinx Version: 1.8.1
  • RTD Theme Version: 0.4.2
munhitsu referenced this issue Dec 10, 2018
This variable is used on the template and evaluated to
give a default value.

According to http://jinja.pocoo.org/docs/2.10/templates/#default
default only works if the variable is undefined,
or passing true as second argument to evaluate to false.
@gaborbernat
Copy link

Ping 👍

@limonkufu
Copy link

This is a problem for 0.5.0 as well. I can't use theme_vcs_pageview_mode variable in the breadcrumbs.html file

@lmgeorge
Copy link

Found a workaround as of 0.5.0: set theme_vcs_pageview_mode(source) in html_context:

html_context = {
    'theme_vcs_pageview_mode': 'edit'
}

@limonkufu
Copy link

@lmgeorge thanks for pointing out the workaround I have been using it since August but didn't post it

Found a workaround as of 0.5.0: set theme_vcs_pageview_mode(source) in html_context:

html_context = {
    'theme_vcs_pageview_mode': 'edit'
}

@stsewd stsewd added the Bug A bug label Oct 8, 2020
stsewd added a commit that referenced this issue Oct 8, 2020
@stsewd
Copy link
Member

stsewd commented Oct 8, 2020

Sorry everyone! I have a fix for this #1010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants