Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on jQuery #1546

Open
kwsp opened this issue Dec 1, 2023 · 0 comments
Open

Remove dependency on jQuery #1546

kwsp opened this issue Dec 1, 2023 · 0 comments
Labels
Bug A bug Needed: replication Bug replication is required

Comments

@kwsp
Copy link

kwsp commented Dec 1, 2023

Problem

jQuery was removed from Sphinx in ~2022 with the release of Sphinx 6.0.0.

I came across this because of broken search functionality at https://pydicom.github.io/pydicom/dev/index.html. I realised the problem is that jQuery is somehow not loaded so searchindex.js isn't loaded. However, this simple need to load a script is trivial in vanilla JS nowadays, as Sphinx by default uses.

If the maintainers don't want to remove jQuery for other downstream projects, at least we can start by porting some of the simply tasks to vanilla JS as Sphinx had done, so when jQuery breaks, it doesn't break the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug Needed: replication Bug replication is required
Projects
None yet
Development

No branches or pull requests

1 participant