Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<kbd> tag doesn't style as expected #1224

Closed
fishermans-friend opened this issue Sep 6, 2021 · 1 comment · Fixed by #967 or #1320
Closed

<kbd> tag doesn't style as expected #1224

fishermans-friend opened this issue Sep 6, 2021 · 1 comment · Fixed by #967 or #1320
Labels
Accepted Accepted issue on our roadmap
Milestone

Comments

@fishermans-friend
Copy link

Problem

As was raised in this issue: #669 it's nice if the <kbd> tag has better styling to indicate that it is intended to represent a button, not just code.

My understanding of it was that this should have been fixed in this pull request #677 but that does not appear to be the case. I can not find the code changed in the PR in the current iteration of the src/sass/_theme_rst.sass, nor does it seem to work in my project.

Reproducible Project

To confirm the selection, hit :kbd:`ENTER`. To go back to the base mode, hit either :kbd:`ESC` or :kbd:`Q`.

Error Logs/Results

Here is the output of the above:

Confirm selection

Expected Results

I know nothing about sass, but I monkeypatched it with the little custom css I have, basing myself on the change in the linked PR with the following css:

kbd, .kbd {
    color: inherit;
    font-size: 80%;
    background-color: #F0F0F0;
    border: 1px solid #D5D5D5;
    border-radius: 4px;
    box-shadow: grey 0px 2px;
    padding: 2.4px 6px;
    margin: auto 0;
}

Which produces the following output instead:

Confirm selection

I'm not sure that's quite right still, but it's a lot closer to the expected output.

Environment Info

  • Python Version: 3.8
  • Sphinx Version: 4.0.1
  • RTD Theme Version: 0.5.1
@fishermans-friend fishermans-friend added Bug A bug Needed: replication Bug replication is required labels Sep 6, 2021
@nienn
Copy link
Contributor

nienn commented Sep 6, 2021

There's already an open PR — #967 — from @Blendify, that's assigned to the 1.1 milestone, to fix this once more.
Apparently the #677 never got merged.

@nienn nienn added Status: blocked Issue is blocked on another issue and removed Bug A bug Needed: replication Bug replication is required labels Sep 6, 2021
@nienn nienn added this to the 1.1 milestone Sep 6, 2021
@benjaoming benjaoming added Accepted Accepted issue on our roadmap and removed Status: blocked Issue is blocked on another issue labels Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap
Projects
None yet
3 participants