Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing issue with HTML4 images #1199

Merged
merged 1 commit into from Aug 12, 2021
Merged

Conversation

agjohnson
Copy link
Collaborator

@agjohnson agjohnson commented Aug 12, 2021

This bug was introduced in #1185, it looks like the HTML4 selector
changed to not include directly descendents of .section elements.

I believe the issue was the missing > introduced here:
https://github.com/readthedocs/sphinx_rtd_theme/pull/1185/files#diff-2ad748ac9ebc515229907afab210e3bb370986d3db3a377f052ee5048dcc5b6cR36

But I'm also not familiar with the element that these rules are trying to target.

Fixes #1198

This bug was introduced in #1185, it looks like the HTML4 selector
changed to not include directly descendents of `.section` elements.
@agjohnson
Copy link
Collaborator Author

@Blendify it's not really clear what the fix in #1185 was addressing, so I'm not exactly sure what to test to verify this change. What was this selector supposed to target? Fix was easy, it seems just the direct descendant selector was missing.

@agjohnson agjohnson added this to the 1.0 milestone Aug 12, 2021
Copy link
Member

@Blendify Blendify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unsure exactly also, we really need to better organize and comment what styling goes to what markup

@agjohnson agjohnson added the Bug A bug label Aug 12, 2021
@agjohnson
Copy link
Collaborator Author

Heh yeah, seems we might have some investigation to do

@agjohnson agjohnson merged commit f0edcba into master Aug 12, 2021
@agjohnson agjohnson deleted the agj/fix-image-spacing-html4 branch August 12, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with image spacing still
2 participants