CSS: Fix oversized logo in IE11 #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
Much better! There is probably an issue or two for this open, as it's been one of the reasons folks have discussed dropping support for IE11. We can probably still discuss dropping IE11 support in an upcoming release, but for now I think most of our issues with IE11 are solved with more CSS and maybe at worst some polyfills.
Blendify
requested changes
Aug 4, 2021
Blendify
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Because the parent
<a>tag didn't had amax-widthset, the child logo, on IE11, was assuming the full image width.Changes
Added
max-widthto the<a>tag wrapping the logo.Before:
After:
