Maintain aria-expanded along with .current in menu #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blendify
approved these changes
Jun 18, 2021
|
The change is acceptable, however chaining them together like you said is probably the best way to go about it |
jonels-msft
force-pushed
the
menu-aria-expanded
branch
from
31589ab
to
55573d5
Compare
Use jquery setter chaining for speed
jonels-msft
force-pushed
the
menu-aria-expanded
branch
from
55573d5
to
44c2960
Compare
|
@Blendify I rebased this and used jQuery chaining for efficiency. |
Blendify
approved these changes
Jun 21, 2021
|
Nice! Can we get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #955
It might be faster to chain the jQuery calls together to avoid running searches twice, or searching for
$('.current')and applying the aria attribute. However just kicking off this PR with a basic fix.