Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align top and side navigation background colors on mobile #1132

Merged
merged 1 commit into from Apr 18, 2021

Conversation

eerimoq
Copy link
Contributor

@eerimoq eerimoq commented Apr 18, 2021

Hello!

This PR aligns top and side navigation background colors on mobile when configured with style_nav_header_background in conf.py. Currently only the background of the side navigation header is affected by the configuration, but it would be great if the top navigation bar in mobile phones was affected as well.

Configuration:

html_theme_options = {
    'style_nav_header_background': '#7289da'
}

Before this PR:
image
image

After this PR:
image
image

Thanks!

@Blendify Blendify merged commit 2026bb6 into readthedocs:master Apr 18, 2021
@eerimoq
Copy link
Contributor Author

eerimoq commented Apr 19, 2021

When do you think this will be released and uploaded to PyPI? =)

@Blendify
Copy link
Member

That is up to either @ericholscher or @agjohnson we have been trying to push out a release soon. Unfortunately, things have been slow from their side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants