Skip to content

Added support for gtag #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 18, 2021
Merged

Added support for gtag #1129

merged 8 commits into from
Jun 18, 2021

Conversation

ThomasTNO
Copy link
Contributor

@ThomasTNO ThomasTNO commented Apr 13, 2021

Solves: #1128

Implements the new gtag.js Google Analytics.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
ThomasTNO Thomas Rooijakkers

Verified

This commit was signed with the committer’s verified signature. The key has expired.
ThomasTNO Thomas Rooijakkers
@Blendify
Copy link
Member

Is gtag backwards compatible with the old ga tracking code?

Verified

This commit was signed with the committer’s verified signature. The key has expired.
ThomasTNO Thomas Rooijakkers
@ThomasTNO
Copy link
Contributor Author

Is gtag backwards compatible with the old ga tracking code?

Yes, it is. https://developers.google.com/analytics/devguides/collection/upgrade/analyticsjs

Verified

This commit was signed with the committer’s verified signature. The key has expired.
ThomasTNO Thomas Rooijakkers
Copy link
Member

@Blendify Blendify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seems fine, one small documentation comment.

@agjohnson is there anything that would cause concern here on read the docs?

Verified

This commit was signed with the committer’s verified signature. The key has expired.
ThomasTNO Thomas Rooijakkers

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ThomasTNO
Copy link
Contributor Author

Will this be taken into account for the next release?

ThomasTNO and others added 2 commits June 2, 2021 09:22

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Blendify Blendify merged commit ef9a058 into readthedocs:master Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants