Use static setuptools metadata #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I still use bumpversion. I'd like to use it on other projects as well too. I'm going to target a future release for this work, after we get a 1.0 release out with some of the current work pending. |
|
Reported the bumpversion issues here #1117 |
astrojuanlu
force-pushed
the
static-metadata
branch
from
7dda1fe
to
1421fb5
Compare
|
Rebased on top of |
|
😄 @agjohnson - just stumbled upon gold here, the bumpversion issues that got introduced in package-lock.json are already |
|
Updated to latest master. I've included the Jinja fix from #1316. |
benjaoming
force-pushed
the
static-metadata
branch
from
f13e6d8
to
68aed97
Compare
benjaoming
approved these changes
Aug 19, 2022
| @@ -86,73 +86,11 @@ def run(self): | |||
|
|
|||
|
|
|||
| setup( | |||
| name='sphinx_rtd_theme', | |||
| version='1.0.1alpha1', | |||
There was a problem hiding this comment.
Shouldn't we also have the version in setup.cfg?
This was referenced Aug 24, 2022
This was referenced Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates most of the metadata keys to the new static/declarative
setup.cfg.Also, I tried fixing the bumpversion configuration, but when I tried
bumpversion microit introduced a few bugs in thepackage-lock.jsonand whitespace changes insetup.cfg, so I am not sure if we are still using it.