Add python version requirements to setup.py #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is need in the future so we can gracefully remove python 2.7 support. See #1075.
agjohnson
reviewed
Mar 17, 2021
|
The python3 versions that were dropped are because sphinx has already dropped support for them when sphinx 1.6 is removed. We require sphinx 1.6 because it is the first version with experimental HTML5 and needed for some other bug fixes in the theme. |
astrojuanlu
reviewed
Mar 29, 2021
astrojuanlu
approved these changes
Jun 23, 2021
There was a problem hiding this comment.
I'm not an expert in the theme but this pull request doesn't do anything revolutionary. Python 3.0 to 3.2 are universally recognized as Bad™, and 3.3 is just too old at this point. As @Blendify has clarified, these versions haven't been supported since Sphinx 1.5 anyway. There are no outstanding discussions left. In summary: I'm merging it. Thanks @Blendify for your persistence!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is need in the future so we can gracefully remove python 2.7 support.
See #1075.
The required python versions are based on sphinx 1.6 which is our minimal required version.
https://packaging.python.org/guides/dropping-older-python-versions/