Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: wrap inline literals #1050

Merged
merged 3 commits into from Feb 23, 2021
Merged

Fix: wrap inline literals #1050

merged 3 commits into from Feb 23, 2021

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Feb 10, 2021 •
edited

This preserves white spaces as is when copying,
so all good.

Before (this even doesn't show a horizontal scrollbar)

Screenshot_2021-02-10 3 Paragraph Level Markup — Read the Docs Sphinx Theme 0 5 1 documentation(2)

After

Screenshot_2021-02-10 3 Paragraph Level Markup — Read the Docs Sphinx Theme 0 5 1 documentation(1)
Screenshot_2021-02-10 3 Paragraph Level Markup — Read the Docs Sphinx Theme 0 5 1 documentation

Fixes #321

@stsewd
Fix: wrap inline literals
147f50d 
This preservers white spaces as is when copying,
so all good.

Fixes #321
@stsewd stsewd requested review from a team February 11, 2021 00:10
Blendify
Blendify reviewed Feb 11, 2021
View reviewed changes
Copy link
Member

@Blendify Blendify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding line-break: anywhere looks a little cleaner here, however not sure what is better, a clean righthand edge, or text readability. Adding this would break words mid-word.

The changes look good, we don't have to take my suggestion but wanted to throw the idea out there.

@Blendify Blendify mentioned this pull request Feb 11, 2021
Closed
@stsewd
Copy link
Member Author

stsewd commented Feb 15, 2021

Thanks for the suggestion! Personally I prefer to not break in the middle of words, let's see what others think. Here are some screenshots with line-break: anywhere

Screenshot_2021-02-15 3 Paragraph Level Markup — Read the Docs Sphinx Theme 0 5 1 documentation(1)
Screenshot_2021-02-15 3 Paragraph Level Markup — Read the Docs Sphinx Theme 0 5 1 documentation

@Blendify
Copy link
Member

I think not breaking words might be best, I don't think users will have this long of a literal so their likely won't be any improvement. If we find this is an issue we can revisit later.

@stsewd stsewd merged commit d91d7e1 into master Feb 23, 2021
@stsewd stsewd deleted the wrap-inlinecode branch February 23, 2021 18:43
@Blendify Blendify mentioned this pull request Apr 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blendify Blendify Blendify approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inline code literals have no wrapping
2 participants
@stsewd @Blendify