Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search does not terminate for terms that are not found. #1037

Closed
noraabiakar opened this issue Jan 18, 2021 · 3 comments · Fixed by #1039
Closed

Search does not terminate for terms that are not found. #1037

noraabiakar opened this issue Jan 18, 2021 · 3 comments · Fixed by #1039
Labels
Bug A bug

Comments

@noraabiakar
Copy link

Problem

Searching for a string in the docs using the search bar does not terminate ( result is stuck on Searching ... ) when the string is not found.

Reproducible Project

This can be reproduced on: https://sphinx-rtd-theme.readthedocs.io/en/latest/ by searching some random string that isn't present.
But has also been observed on: https://arbor.readthedocs.io/en/latest/ which uses this theme.

Expected Results:

This message to be displayed instead (or something similar):
Your search did not match any documents. Please make sure that all words are spelled correctly and that you've selected enough categories.

Environment Info

  • Python Version: Python3.7
  • Sphinx Version: v3.4.3
  • RTD Theme Version: v0.5.1 (as well as master)
@stsewd
Copy link
Member

stsewd commented Jan 18, 2021

This seems related to the sphinx change #1021, maybe something with our extension and not with the theme.

@stsewd stsewd added the Bug A bug label Jan 18, 2021
@stsewd
Copy link
Member

stsewd commented Jan 18, 2021

I think I know were the problem is, this is because we install by default an old version of the theme, you should pin your version to 0.5.1 (this is fixed there). For our docs we need to install it with pip

stsewd added a commit that referenced this issue Jan 18, 2021
stsewd added a commit that referenced this issue Jan 18, 2021
@Blendify
Copy link
Member

This was fixed with 24f8e31, note the theme currently is using an old version of the theme so that's why our search is bugged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
3 participants