Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search popup is unwieldy on desktop (considere using a drop down menu) #73

Closed
stijn-h opened this issue Sep 1, 2020 · 4 comments
Closed
Labels
Needed: design decision A core team decision is required

Comments

@stijn-h
Copy link

stijn-h commented Sep 1, 2020

Searching is not a pleasant experience, and it's mainly because of a slow, (assumably) mobile-first search popup. While I can't speak for every documentation website, at least for the repository I'm working with (Godot Engine), desktop monitors should be the primary device to target for user experience. Example in the Godot Engine docs:

search_godot

A better instant search would only take up a modest amount of space under the search bar, and not take away the ability to use the current page. This would likely imply different search UI on mobile and desktop devices.

@stsewd
Copy link
Member

stsewd commented Sep 1, 2020

and it's mainly because of a slow, (assumably) mobile-first search popup

Do you mean the transition is slow? It should be faster now #66

A better instant search would only take up a modest amount of space under the search bar, and not take away the ability to use the current page. This would likely imply different search UI on mobile and desktop devices.

Some other sites like mkdocs have the modal window like this as well https://www.mkdocs.org/.

I guess we can have something like an option to minimize the modal window?

@stijn-h
Copy link
Author

stijn-h commented Sep 2, 2020

Those changes should help, but I still feel that it leaves much to be desired. I guess the idea behind the large popup is that search results aren't single line suggestions like in a usual drop down. However, even in the smaller example you gave, it prevents you from using or reading the current page you are on while searching.

@stsewd
Copy link
Member

stsewd commented Sep 2, 2020

Those changes should help, but I still feel that it leaves much to be desired

Do you mean related to speed?

However, even in the smaller example you gave, it prevents you from using or reading the current page you are on while searching.

Which example? Do you mean the mkdocs search?

@stijn-h
Copy link
Author

stijn-h commented Sep 3, 2020

Do you mean the mkdocs search?

Yes. I would prefer a list of search suggestions that dont take away control from the webpage, like in this example.

@stsewd stsewd changed the title Search popup is unwieldy on desktop Search popup is unwieldy on desktop (considere using a drop down menu) Jan 21, 2021
@stsewd stsewd added the Needed: design decision A core team decision is required label Jan 21, 2021
@stijn-h stijn-h closed this as completed Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

2 participants