Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace search dropdown filter on project/version/etc listing views #343

Closed
3 tasks done
agjohnson opened this issue Apr 24, 2024 · 1 comment · Fixed by #351
Closed
3 tasks done

Replace search dropdown filter on project/version/etc listing views #343

agjohnson opened this issue Apr 24, 2024 · 1 comment · Fixed by #351
Assignees
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@agjohnson
Copy link
Contributor

agjohnson commented Apr 24, 2024

Currently, there are a few mock filters that use API driven mechanism to search/etc. These are old implementations and have been updated with some modern work on newer Django filters.

These are the filters that I'm describing:

image

For example, on the organization listing view, the dropdown is a simple filter object and is displayed as normal from the filter menu:

image

These last two filters can be updated to match, which would also remove some of the bad UX around this filter UI.

Places this pattern was used:

  • Project listing view
  • Project version listing view
  • Build listing view
@agjohnson agjohnson added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Apr 24, 2024
@agjohnson agjohnson self-assigned this Apr 24, 2024
@agjohnson
Copy link
Contributor Author

I've combined this work with #250

It's working great I think. This deletes a lot of JS code from our dashboard, moving the code to django-filter Python logic, which I think is another win. I didn't go as far as to use web components for the client side logic, as the majority of this is still application template driven.

But for now, the filters feel a bit easier to use:

Screencast.from.2024-05-16.18-29-50.webm

agjohnson added a commit that referenced this issue May 17, 2024
This drops the custom API driven filters and relies on application
FilterSet instances instead, matching the rest of the filter fields.
Because of this, we are able to delete much of the JS and API logic from
the dashboard side.

- Fixes #343
- Closes #250
- Requires changes on our application filters
humitos pushed a commit that referenced this issue May 21, 2024
* Listing filter UX changes

This drops the custom API driven filters and relies on application
FilterSet instances instead, matching the rest of the filter fields.
Because of this, we are able to delete much of the JS and API logic from
the dashboard side.

- Fixes #343
- Closes #250
- Requires changes on our application filters

* Fix docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant