Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404: where "Go back" link should go if the history is empty? #335

Open
humitos opened this issue Apr 18, 2024 · 0 comments
Open

404: where "Go back" link should go if the history is empty? #335

humitos opened this issue Apr 18, 2024 · 0 comments
Labels
Improvement Minor improvement to code

Comments

@humitos
Copy link
Member

humitos commented Apr 18, 2024

When hitting a 404 page from the new dashboard, we show a "Go back" button that calls javascript:history.back(). However, it's pretty common to have nothing in the history, making that button to do nothing. We should probably check for this and link to the home or not even show that button.

Screenshot_2024-04-18_18-02-25

@humitos humitos added the Improvement Minor improvement to code label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

1 participant